Skip to content

Commit b204d80

Browse files
committed
clarifications in Export to Application for macOS
1 parent 4c3fb50 commit b204d80

2 files changed

Lines changed: 17 additions & 11 deletions

File tree

java/src/processing/mode/java/ExportPrompt.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ protected boolean trigger() throws IOException, SketchException {
206206
final String warning1 =
207207
"<html><div width=\"" + divWidth + "\">";
208208
final String warning2a =
209-
"Embedding Java will make the " + platformName + " application " +
209+
"This option will make the " + platformName + " application " +
210210
"larger, but it will be far more likely to work. " +
211211
"Users on other platforms will need to ";
212212
final String warning2b =
@@ -226,7 +226,7 @@ public void mousePressed(MouseEvent event) {
226226
}
227227
});
228228
warningLabel.setBorder(new EmptyBorder(3, 13, 3, 13));
229-
warningLabel.putClientProperty("FlatLaf.styleClass", "medium");
229+
// warningLabel.putClientProperty("FlatLaf.styleClass", "medium");
230230

231231
final JCheckBox embedJavaButton =
232232
new JCheckBox(Language.interpolate("export.include_java", Platform.getPrettyName()));
@@ -262,24 +262,25 @@ public void mousePressed(MouseEvent event) {
262262

263263
//if (false && new File("/usr/bin/codesign_allocate").exists()) {
264264
if (JavaBuild.isXcodeInstalled()) {
265-
thePain +=
265+
thePain += "<br/>" +
266266
"This application will be \u201Cself-signed\u201D which means that " +
267-
"macOS may complain that is from an unidentified developer. " +
267+
"macOS may complain that it comes from an unidentified developer. " +
268268
"If the application will not run, try right-clicking the app and " +
269269
"selecting Open from the pop-up menu. " +
270270
"More details at the <a href=\"\">Exporting Applications</a> wiki page.";
271271
} else {
272272
thePain +=
273-
"To sign the app, <a href=\"\">click here</a> to begin " +
274-
"installing the Command Line Tools from Apple. ";
273+
"To create a working macOS application, " +
274+
"<a href=\"\">click here</a> to install " +
275+
"the Command Line Tools from Apple.";
275276
}
276277

277278
// Are you f-king serious, Java API developers?
278279
// (Unless it's an HTML component, even with line wrap turned on,
279280
// getPreferredSize() will return the size for just a single line.)
280281
// JLabel area = new JLabel("<html><div width=\"" + divWidth + "\"><font size=\"2\">" + thePain + "</div></html>");
281282
JLabel area = new JLabel("<html><div width=\"" + divWidth + "\">" + thePain + "</div></html>");
282-
area.putClientProperty("FlatLaf.styleClass", "medium");
283+
// area.putClientProperty("FlatLaf.styleClass", "medium");
283284

284285
area.setBorder(new EmptyBorder(3, 13, 3, 13));
285286
// Using area.setPreferredSize() here doesn't help,

todo.txt

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,13 @@ X figure out if we can do anything with signing applications
4343
X https://developer.apple.com/forums/thread/128166
4444
X https://developer.apple.com/forums/thread/701514#701514021
4545
X https://developer.apple.com/forums/thread/701581#701581021
46+
/ Xcode command line tools must be installed first
47+
/ show a message before even opening the Export dialog
48+
X can't restrict to installation b/c may want to do other platforms
49+
X or detection of the CLT may not be correct
50+
X or users may be doing their own manual signing anyway
51+
X for now, just cleaning up the messages a bit for clarity
52+
X and bump the font size back up for legibility
4653

4754
docs
4855
X update theme instructions
@@ -373,10 +380,8 @@ old things
373380
+ Examples window (Casey will pick 3-4)
374381
* Reference, Discourse, Github, Wiki
375382

376-
377-
378-
_ Xcode command line tools must be installed first
379-
_ show a message before even opening the Export dialog
383+
_ recent errors from AndroidMode
384+
_ add a note about underscores in sketch tabs in prefs doc
380385

381386

382387
detach sketch names

0 commit comments

Comments
 (0)