looking into why Python Mode for 3.x was loading

benfry · benfry · commit a6d602e90404 · 2023-01-14T22:26:32.000-05:00
diff --git a/app/src/processing/app/Base.java b/app/src/processing/app/Base.java
@@ -773,10 +773,8 @@ void rebuildContribModes() {
       contribModes = new ArrayList<>();
     }
     File modesFolder = getSketchbookModesFolder();
-    List<ModeContribution> knownList = getContribModes();
-
     Map<File, ModeContribution> known = new HashMap<>();
-    for (ModeContribution contrib : knownList) {
+    for (ModeContribution contrib : getContribModes()) {
       known.put(contrib.getFolder(), contrib);
     }
     File[] potential = ContributionType.MODE.listCandidates(modesFolder);
diff --git a/app/src/processing/app/contrib/ContributionType.java b/app/src/processing/app/contrib/ContributionType.java
@@ -136,6 +136,10 @@ public boolean isCandidate(File potential) {
 
   /**
    * Whether this contrib is compatible with this revision of Processing.
+   * Unfortunately, this requires the author to properly set this value.
+   * For instance, with “Python Mode for Processing 3” the max revision
+   * is set to 0 in mode.properties (meaning all newer Processing versions),
+   * even though it properly maxes out with 3.x in contribs.txt.
    */
   private boolean isCompatible(File contribFolder) {
     StringDict properties = loadProperties(contribFolder);
diff --git a/todo.txt b/todo.txt
@@ -84,17 +84,17 @@ X updateDetail() call in StatusPanel.updateTheme()
 o   move to ListPanel.updateTheme() (why wasn't it there?)
 X   ugh, it's called twice, right nearby each other; yikes
 X   fix the double call, but just need to get rid of progress bars anyway
-
+X if Python Mode for 3.x is installed, it's allowed to be used and loaded
+o   shouldn't be loading it on startup if it's not compatible
+o   does this apply to other libraries as well?
+X   added checks for compatibility to ContributionType.isCandidate()
+X   but with Python Mode for 3.x, the problem is maxRevision is set to 0
+X   filed an issue https://github.com/jdf/processing.py/issues/406
 
 _ Update All with several entries is really locking things up
 _   not clear if it's work being done on the EDT
 _   or that all the threads are running immediately (rather than sequentially)
 
-
-_ if Python Mode for 3.x is installed, it's allowed to be used and loaded
-_   shouldn't be loading it on startup if it's not compatible
-_   does this apply to other libraries as well?
-
 _ rip out JProgressBar from StatusPanel/StatusDetail
 _   show progress in the list instead
 _   also make possible to start install by clicking the list
@@ -109,6 +109,7 @@ _   (was this for the contrib listing? or an actual contrib?)
 _ Base.setUpdatesAvailable() is called from half a dozen places!?
 _ how to handle contrib manager download/retry/etc and showing progress
 
+
 _ make note in docs that .properties file *must* be utf-8 (usually iso8859-1)
 _   if not it'll make things gross (andre sier flob library)
 

Original file line number	Diff line number	Diff line change
`@@ -773,10 +773,8 @@ void rebuildContribModes() {`
`773`	`773`	`contribModes = new ArrayList<>();`
`774`	`774`	`}`
`775`	`775`	`File modesFolder = getSketchbookModesFolder();`
`776`		`- List<ModeContribution> knownList = getContribModes();`
`777`		`-`
`778`	`776`	`Map<File, ModeContribution> known = new HashMap<>();`
`779`		`- for (ModeContribution contrib : knownList) {`
	`777`	`+ for (ModeContribution contrib : getContribModes()) {`
`780`	`778`	`known.put(contrib.getFolder(), contrib);`
`781`	`779`	`}`
`782`	`780`	`File[] potential = ContributionType.MODE.listCandidates(modesFolder);`