remove java.class.path when launching code from inside the PDE

benfry · benfry · commit 8d0a26662120 · 2021-06-26T21:19:16.000-04:00
diff --git a/core/todo.txt b/core/todo.txt
@@ -6,6 +6,7 @@ _ mouseButton not set correctly on mouseReleased() with Java2D
 _   https://github.com/processing/processing4/issues/181
 _   https://github.com/processing/processing4/pull/188
 
+_ put opengl libs for core into platform-specific subfolders?
 
 _ setting surface size needs to happen outside draw()
 _   surface.setSize() sadness etc
diff --git a/java/src/processing/mode/java/JavaBuild.java b/java/src/processing/mode/java/JavaBuild.java
@@ -308,6 +308,11 @@ public String preprocess(File srcFolder,
       }
     }
 
+    // Turning this off after 4.0 alpha 5, to see if everything still works.
+    // Including this classpath is really problematic (many possible conflicts,
+    // these are classes that won't be available on export, etc etc...)
+    // Also avoids accidentally hiding other potential classpath bugs.
+    /*
     // Finally, add the regular Java CLASSPATH. This contains everything
     // imported by the PDE itself (core.jar, pde.jar, quaqua.jar) which may
     // in fact be more of a problem.
@@ -317,6 +322,7 @@ public String preprocess(File srcFolder,
       javaClassPath = javaClassPath.substring(1, javaClassPath.length() - 1);
     }
     classPath += File.pathSeparator + javaClassPath;
+    */
 
     // But make sure that there isn't anything in there that's missing,
     // otherwise ECJ will complain and die. For instance, Java 1.7 (or maybe
diff --git a/todo.txt b/todo.txt
@@ -1,4 +1,6 @@
 1275 (4.0a6)
+X remove java.class.path when launching code from inside the PDE
+X   should prevent conflicts, avoid papering over other bugs
 
 
 contribs

Original file line number	Diff line number	Diff line change
`@@ -308,6 +308,11 @@ public String preprocess(File srcFolder,`
`308`	`308`	`}`
`309`	`309`	`}`
`310`	`310`
	`311`	`+ // Turning this off after 4.0 alpha 5, to see if everything still works.`
	`312`	`+ // Including this classpath is really problematic (many possible conflicts,`
	`313`	`+ // these are classes that won't be available on export, etc etc...)`
	`314`	`+ // Also avoids accidentally hiding other potential classpath bugs.`
	`315`	`+ /*`
`311`	`316`	`// Finally, add the regular Java CLASSPATH. This contains everything`
`312`	`317`	`// imported by the PDE itself (core.jar, pde.jar, quaqua.jar) which may`
`313`	`318`	`// in fact be more of a problem.`
`@@ -317,6 +322,7 @@ public String preprocess(File srcFolder,`
`317`	`322`	`javaClassPath = javaClassPath.substring(1, javaClassPath.length() - 1);`
`318`	`323`	`}`
`319`	`324`	`classPath += File.pathSeparator + javaClassPath;`
	`325`	`+ */`
`320`	`326`
`321`	`327`	`// But make sure that there isn't anything in there that's missing,`
`322`	`328`	`// otherwise ECJ will complain and die. For instance, Java 1.7 (or maybe`