fix "could not parse -1 for --display" message

benfry · benfry · commit dd9f2404f8be · 2019-02-03T16:22:17.000-05:00
diff --git a/build/shared/revisions.txt b/build/shared/revisions.txt
@@ -19,6 +19,7 @@ and includes a handful of other smaller fixes.
 + Ignore .class files found in the META-INF folder for imported JARs
   https://github.com/processing/processing/issues/5778
 
++ Get rid of errant 'Could not parse -1 for display' message.
 
 + Fix up and clean a few file i/o issues that were causing resource
   leaks with loadXxxx() commands, and intermediate folders not being
diff --git a/core/src/processing/core/PApplet.java b/core/src/processing/core/PApplet.java
@@ -10758,9 +10758,11 @@ public void uncaughtException(Thread t, Throwable e) {
           editorLocation = parseInt(split(value, ','));
 
         } else if (param.equals(ARGS_DISPLAY)) {
-          displayNum = parseInt(value, -1);
-          if (displayNum == -1) {
-            System.err.println("Could not parse " + value + " for " + ARGS_DISPLAY);
+          displayNum = parseInt(value, -2);
+          if (displayNum == -2) {
+            // this means the display value couldn't be parsed properly
+            System.err.println(value + " is not a valid choice for " + ARGS_DISPLAY);
+            displayNum = -1;  // use the default
           }
 
         } else if (param.equals(ARGS_WINDOW_COLOR)) {
diff --git a/core/todo.txt b/core/todo.txt
@@ -3,6 +3,7 @@ X fix/clean a few file i/o issues
 X   deal with possible resource leak when loading URLs
 X   create intermediate folders when saving temp files
 X   fix resource leaks (open files) in loadJSONObject and loadJSONArray
+X get rid of errant 'Could not parse -1 for display' message
 
 contrib
 X Update missing @Deprecated tags in PApplet.java
