ignore .class files in META-INF subfolder (fixes #5778)

benfry · benfry · commit b9049243bd74 · 2019-01-28T17:01:23.000-05:00
diff --git a/app/src/processing/app/Util.java b/app/src/processing/app/Util.java
@@ -559,15 +559,14 @@ static private void packageListFromZip(String filename, StringList list) {
         if (!entry.isDirectory()) {
           String name = entry.getName();
 
-          if (name.endsWith(".class")) {
+          // Avoid META-INF because some jokers but .class files in there
+          // https://github.com/processing/processing/issues/5778
+          if (name.endsWith(".class") && !name.startsWith("META-INF/")) {
             int slash = name.lastIndexOf('/');
-            if (slash == -1) continue;
-
-            String pname = name.substring(0, slash);
-//            if (map.get(pname) == null) {
-//              map.put(pname, new Object());
-//            }
-            list.appendUnique(pname);
+            if (slash != -1) {
+              String packageName = name.substring(0, slash);
+              list.appendUnique(packageName);
+            }
           }
         }
       }
diff --git a/todo.txt b/todo.txt
@@ -7,7 +7,8 @@ X fix an editor problem with plain text (css, etc) files
 X   https://github.com/processing/processing/issues/5628
 X default to using Desktop methods for URLs and files when available on Linux
 X   also cover a few weird cases that were failing silently
-
+X The package "META" does not exist when .class files found in META-INF folder
+X   https://github.com/processing/processing/issues/5778
 
 contrib
 X update translation of "sketch" for Russian speakers
