Skip to content

Commit b4cd79d

Browse files
benfrybenfry
committed
misc cleaning activities
1 parent 3f94247 commit b4cd79d

File tree

5 files changed

+41
-21
lines changed

5 files changed

+41
-21
lines changed

‎app/src/processing/app/Preferences.java‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
* sounds like a lot of work. Not unlike writing this paragraph.
4646
*/
4747
public class Preferences {
48-
// had to rename this file because people were editing it
48+
// had to rename the defaults file because people were editing it
4949
static final String DEFAULTS_FILE = "defaults.txt"; //$NON-NLS-1$
5050
static final String PREFS_FILE = "preferences.txt"; //$NON-NLS-1$
5151

@@ -151,8 +151,9 @@ static public void init() {
151151
}
152152
}
153153

154-
static public File getPreferencesFile() {
155-
return preferencesFile;
154+
155+
static protected String getPreferencesPath() {
156+
return preferencesFile.getAbsolutePath();
156157
}
157158

158159

‎app/src/processing/app/PreferencesFrame.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ public void stateChanged(ChangeEvent e) {
526526
right = Math.max(right, left + d.width);
527527
top += d.height; // + GUI_SMALL;
528528

529-
label = new JLabel(Preferences.getPreferencesFile().getAbsolutePath());
529+
label = new JLabel(Preferences.getPreferencesPath());
530530
final JLabel clickable = label;
531531
label.addMouseListener(new MouseAdapter() {
532532
public void mousePressed(MouseEvent e) {

‎app/src/processing/app/contrib/Contribution.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import java.util.Arrays;
2626
import java.util.List;
2727

28-
import processing.app.Language;
2928
import processing.core.PApplet;
3029

3130

‎core/todo.txt‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,8 @@ _ test with JG's 13" retina laptop
123123

124124

125125
decisions/misc
126+
_ use enums for constants
127+
_ https://github.com/processing/processing/issues/2778
126128
_ make join() work with Iterable?
127129
_ will this collide with the current String[] version?
128130
_ add options for image.save() (or saveImage?)

‎todo.txt‎

Lines changed: 34 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ _ Fix OS X menu to be the same order as the other File menu
1212
_ remove toolbar menu references and code to rebuild
1313

1414
gsoc
15+
X remove dependency on oscp5 library for tweak mode
16+
_ https://github.com/processing/processing/issues/2730
17+
X https://github.com/processing/processing/pull/2808
1518
X fixes for mode/tool installation
1619
X https://github.com/processing/processing/pull/2705
1720
X fix mode updating to work properly
@@ -30,8 +33,32 @@ X Code completion: Hide overloaded methods unless inside parentheses
3033
X https://github.com/processing/processing/issues/2755
3134
X Close auto-completion suggestion box when deleting/backspacing code
3235
X https://github.com/processing/processing/issues/2757
33-
_ remove dependency on oscp5 library for tweak mode
34-
_ https://github.com/processing/processing/issues/2730
36+
X error checking too aggressive in the current alpha
37+
X https://github.com/processing/processing/issues/2677
38+
X if 'void' left out before loop or setup, cryptic message about
39+
X 'constructor loop must be named Temporary_23498_2343'
40+
X add a better handler for this specific thing?
41+
X http://code.google.com/p/processing/issues/detail?id=8
42+
X https://github.com/processing/processing/issues/47
43+
X Improve how the Contributions Manager handles no internet connection
44+
X https://github.com/processing/processing/pull/2800
45+
X Added examples-package as a new contribution type
46+
X https://github.com/processing/processing/pull/2795
47+
X https://github.com/processing/processing/issues/2444
48+
X https://github.com/processing/processing/issues/2582
49+
X Contributions Managers now show specific titles
50+
X https://github.com/processing/processing/pull/2777
51+
X Add rank (starred / recommended) to contributions manager items
52+
X https://github.com/processing/processing/issues/2580
53+
o Improve detection and handling of missing semicolons
54+
o http://code.google.com/p/processing/issues/detail?id=136
55+
X should be fixed with PDE X (closed by Dan
56+
X https://github.com/processing/processing/issues/175
57+
X missing brackets, unmatched brackets
58+
X examples added to the bug report
59+
X http://code.google.com/p/processing/issues/detail?id=6
60+
X closed by Shiffman, working better now
61+
X https://github.com/processing/processing/issues/45
3562

3663
pulls
3764
X Add polling to detect file system changes
@@ -82,9 +109,11 @@ X https://github.com/processing/processing/issues/1855
82109
X https://github.com/processing/processing/issues/1816
83110
X Fix unneeded scroll bar display in code completion suggestion box
84111
X https://github.com/processing/processing/pull/2763
85-
86-
_ PDE erroneously detects changes in non-sketch files
87-
_ https://github.com/processing/processing/issues/2759
112+
X PDE erroneously detects changes in non-sketch files
113+
X https://github.com/processing/processing/pull/2794
114+
X https://github.com/processing/processing/issues/2759
115+
X Catch MissingResourceException when language key is missing
116+
X https://github.com/processing/processing/pull/2780
88117

89118
languages
90119
X Japanese https://github.com/processing/processing/pull/2688
@@ -396,10 +425,6 @@ _ http://www.javalobby.org/java/forums/t19012.html
396425

397426
PDE / Compiler & Preprocessor
398427

399-
need examples
400-
_ Improve detection and handling of missing semicolons
401-
_ http://code.google.com/p/processing/issues/detail?id=136
402-
403428
medium (bugs/features)
404429
_ modify build to insert these after antlr run:
405430
_ @SuppressWarnings({"unused", "cast"})
@@ -413,9 +438,6 @@ _ e.g. no setup()/draw() block
413438
_ don't allow "for (blah; blah; blah) ;"
414439
_ or if (blah blah blah) ;
415440
_ it's never useful. students can use { } if they want an empty block
416-
_ missing brackets, unmatched brackets
417-
_ examples added to the bug report
418-
_ http://code.google.com/p/processing/issues/detail?id=6
419441

420442
low (features)
421443
_ copy running code from /tmp/buildXXxxx on crash of p5
@@ -444,10 +466,6 @@ _ http://code.google.com/p/processing/issues/detail?id=494
444466
low (better error messages)
445467
_ single line of code with no semicolon dies with "unexpected token: null"
446468
_ http://code.google.com/p/processing/issues/detail?id=1312
447-
_ if 'void' left out before loop or setup, cryptic message about
448-
_ 'constructor loop must be named Temporary_23498_2343'
449-
_ add a better handler for this specific thing?
450-
_ http://code.google.com/p/processing/issues/detail?id=8
451469

452470

453471
PDE / Editor

0 commit comments

Comments
 (0)