rename-variable menu allows Java identifiers

jeremydouglass · web-flow · commit af1e2ee4ef95 · 2019-08-11T23:29:43.000-07:00
Previously it was limited to unicode identifiers--for example a beginning with _ was forbidden; not so in Java. Closes #5828 "rename-variable dialog doesn't allow 1st-char underscore"
diff --git a/java/src/processing/mode/java/pdex/Rename.java b/java/src/processing/mode/java/pdex/Rename.java
@@ -129,8 +129,8 @@ public void componentHidden(ComponentEvent e) {
         final String newName = textField.getText().trim();
         if (!newName.isEmpty()) {
           if (newName.length() >= 1 &&
-              newName.chars().limit(1).allMatch(Character::isUnicodeIdentifierStart) &&
-              newName.chars().skip(1).allMatch(Character::isUnicodeIdentifierPart)) {
+              newName.chars().limit(1).allMatch(Character::isJavaIdentifierStart) &&
+              newName.chars().skip(1).allMatch(Character::isJavaIdentifierPart)) {
             rename(ps, binding, newName);
             window.setVisible(false);
           } else {
@@ -332,4 +332,4 @@ void dispose() {
       window.dispose();
     }
   }
-}
+}
