scrubbing the class paths for #3812

benfry · benfry · commit 99751b42f77c · 2015-09-21T18:28:55.000-04:00
diff --git a/java/src/processing/mode/java/JavaMode.java b/java/src/processing/mode/java/JavaMode.java
@@ -266,13 +266,14 @@ public boolean handleExportApplication(Sketch sketch) throws SketchException, IO
 
 
   /**
-   * Any modes that extend JavaMode can override this method to add additional jars to be
-   * included in the classpath for code completion and error checking
+   * Any modes that extend JavaMode can override this method to add additional
+   * JARs to be included in the classpath for code completion and error checking
    * @return searchPath: file-paths separated by File.pathSeparatorChar
    */
   public String getSearchPath() {
     // Java Mode doesn't need any default external jars at the moment.
-    return "";
+    // This is here for Android Mode so that it can add its android.jar file.
+    return null;
   }
 
 
diff --git a/java/src/processing/mode/java/pdex/ASTGenerator.java b/java/src/processing/mode/java/pdex/ASTGenerator.java
@@ -111,6 +111,7 @@
 import processing.app.Util;
 import processing.app.syntax.JEditTextArea;
 import processing.app.ui.Toolkit;
+import processing.data.StringList;
 import processing.mode.java.JavaEditor;
 import processing.mode.java.JavaMode;
 import processing.mode.java.preproc.PdePreprocessor;
@@ -295,36 +296,43 @@ protected void done() {
    */
   protected ClassPath classPath;
 
-  //protected JFrame frmJavaDoc;
-
-  protected String getJavaSearchPath() {
-    return System.getProperty("java.class.path") +
-            File.pathSeparatorChar + System.getProperty("java.home") +
-            File.separator + "lib" + File.separator + "rt.jar";
-  }
 
   /**
    * Loads up .jar files and classes defined in it for completion lookup
    */
   protected void loadJars() {
     factory = new ClassPathFactory();
 
-    StringBuilder path = new StringBuilder();
-    String modeClassPath = getJavaSearchPath() + File.pathSeparatorChar + ((JavaMode) editor.getMode()).getSearchPath();
+    StringList entries = new StringList();
+    entries.append(System.getProperty("java.class.path"));
+    entries.append(System.getProperty("java.home") +
+                   File.separator + "lib" + File.separator + "rt.jar");
+
+    String modeClassPath = ((JavaMode) editor.getMode()).getSearchPath();
     if (modeClassPath != null) {
-      path.append(modeClassPath);
+      entries.append(modeClassPath);
     }
 
     if (errorCheckerService.classpathJars != null) {
       synchronized (errorCheckerService.classpathJars) {
         for (URL jarPath : errorCheckerService.classpathJars) {
-          //log(jarPath.getPath());
-          path.append(jarPath.getPath() + File.pathSeparatorChar);
+          entries.append(jarPath.getPath());
         }
       }
     }
 
-    classPath = factory.createFromPath(path.toString());
+//    // Just in case, make sure we don't run off into oblivion
+//    String workingDirectory = System.getProperty("user.dir");
+//    if (entries.removeValue(workingDirectory) != -1) {
+//      System.err.println("user.dir found in classpath");
+//    }
+
+//    // hm, these weren't problematic either
+//    entries.append(System.getProperty("user.dir"));
+//    entries.append("");
+//    entries.print();
+
+    classPath = factory.createFromPath(entries.join(File.pathSeparator));
     log("Classpath created " + (classPath != null));
     log("Sketch classpath jars loaded.");
     if (Platform.isMacOS()) {
diff --git a/java/src/processing/mode/java/pdex/ErrorCheckerService.java b/java/src/processing/mode/java/pdex/ErrorCheckerService.java
@@ -887,17 +887,18 @@ protected void prepareCompilerClasspath() {
             e2.printStackTrace();
           }
         }
-
-
       }
 
       // Also add jars specified in mode's search path
-      String modeJars[] = ((JavaMode) getEditor().getMode()).getSearchPath().split(File.pathSeparatorChar + "");
-      for (String mj : modeJars) {
-        try {
-          classpathJars.add(new File(mj).toURI().toURL());
-        } catch (MalformedURLException e) {
-          e.printStackTrace();
+      String searchPath = ((JavaMode) getEditor().getMode()).getSearchPath();
+      if (searchPath != null) {
+        String[] modeJars = PApplet.split(searchPath, File.pathSeparatorChar);
+        for (String mj : modeJars) {
+          try {
+            classpathJars.add(new File(mj).toURI().toURL());
+          } catch (MalformedURLException e) {
+            e.printStackTrace();
+          }
         }
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -887,17 +887,18 @@ protected void prepareCompilerClasspath() {`
`887`	`887`	`e2.printStackTrace();`
`888`	`888`	`}`
`889`	`889`	`}`
`890`		`-`
`891`		`-`
`892`	`890`	`}`
`893`	`891`
`894`	`892`	`// Also add jars specified in mode's search path`
`895`		`- String modeJars[] = ((JavaMode) getEditor().getMode()).getSearchPath().split(File.pathSeparatorChar + "");`
`896`		`- for (String mj : modeJars) {`
`897`		`- try {`
`898`		`- classpathJars.add(new File(mj).toURI().toURL());`
`899`		`- } catch (MalformedURLException e) {`
`900`		`- e.printStackTrace();`
	`893`	`+ String searchPath = ((JavaMode) getEditor().getMode()).getSearchPath();`
	`894`	`+ if (searchPath != null) {`
	`895`	`+ String[] modeJars = PApplet.split(searchPath, File.pathSeparatorChar);`
	`896`	`+ for (String mj : modeJars) {`
	`897`	`+ try {`
	`898`	`+ classpathJars.add(new File(mj).toURI().toURL());`
	`899`	`+ } catch (MalformedURLException e) {`
	`900`	`+ e.printStackTrace();`
	`901`	`+ }`
`901`	`902`	`}`
`902`	`903`	`}`
`903`	`904`	`}`