cleaning up from PRs, other todo items

benfry · benfry · commit 48b44cb303d1 · 2019-01-23T11:30:14.000-05:00
diff --git a/app/src/processing/app/contrib/ContributionListing.java b/app/src/processing/app/contrib/ContributionListing.java
@@ -159,7 +159,7 @@ private void addContribution(Contribution contribution) {
         Collections.sort(list, COMPARATOR);
 
       } else {
-        ArrayList<Contribution> list = new ArrayList<Contribution>();
+        ArrayList<Contribution> list = new ArrayList<>();
         list.add(contribution);
         librariesByCategory.put(category, list);
       }
@@ -210,7 +210,7 @@ protected AvailableContribution getAvailableContribution(Contribution info) {
 
 
   protected Set<String> getCategories(Contribution.Filter filter) {
-    Set<String> outgoing = new HashSet<String>();
+    Set<String> outgoing = new HashSet<>();
 
     Set<String> categorySet = librariesByCategory.keySet();
     for (String categoryName : categorySet) {
@@ -426,28 +426,6 @@ public void run() {
   }
 
 
-  /*
-  boolean hasUpdates(Base base) {
-    for (ModeContribution mc : base.getModeContribs()) {
-      if (hasUpdates(mc)) {
-        return true;
-      }
-    }
-    for (Library lib : base.getActiveEditor().getMode().contribLibraries) {
-      if (hasUpdates(lib)) {
-        return true;
-      }
-    }
-    for (ToolContribution tc : base.getToolContribs()) {
-      if (hasUpdates(tc)) {
-        return true;
-      }
-    }
-    return false;
-  }
-  */
-
-
   protected boolean hasUpdates(Contribution contribution) {
     if (contribution.isInstalled()) {
       Contribution advertised = getAvailableContribution(contribution);
@@ -482,7 +460,7 @@ protected boolean hasListDownloadFailed() {
 
   private List<AvailableContribution> parseContribList(File file) {
     List<AvailableContribution> outgoing =
-      new ArrayList<AvailableContribution>();
+      new ArrayList<>();
 
     if (file != null && file.exists()) {
       String[] lines = PApplet.loadStrings(file);
diff --git a/core/src/processing/core/PApplet.java b/core/src/processing/core/PApplet.java
@@ -141,7 +141,6 @@ public class PApplet implements PConstants {
    * Do not use; javaPlatform or javaVersionName are better options.
    * For instance, javaPlatform is useful when you need a number for
    * comparison, i.e. "if (javaPlatform >= 9)".
-   * @deprecated
    */
   @Deprecated
   public static final float javaVersion = 1 + javaPlatform / 10f;
@@ -8299,9 +8298,8 @@ static public void arrayCopy(Object src, Object dst) {
     System.arraycopy(src, 0, dst, 0, Array.getLength(src));
   }
 
-  //
   /**
-   * @deprecated Use arrayCopy() instead.
+   * Use arrayCopy() instead.
    */
   @Deprecated
   static public void arraycopy(Object src, int srcPosition,
@@ -8311,21 +8309,22 @@ static public void arraycopy(Object src, int srcPosition,
   }
 
   /**
-   * @deprecated Use arrayCopy() instead.
+   * Use arrayCopy() instead.
    */
   @Deprecated
   static public void arraycopy(Object src, Object dst, int length) {
     System.arraycopy(src, 0, dst, 0, length);
   }
 
   /**
-   * @deprecated Use arrayCopy() instead.
+   * Use arrayCopy() instead.
    */
   @Deprecated
   static public void arraycopy(Object src, Object dst) {
     System.arraycopy(src, 0, dst, 0, Array.getLength(src));
   }
 
+
   /**
    * ( begin auto-generated from expand.xml )
    *
@@ -12115,11 +12114,11 @@ public void rect(float a, float b, float c, float d,
   /**
    * ( begin auto-generated from square.xml )
    *
-   * Draws a square to the screen. A square is a four-sided shape with 
-   * every angle at ninety degrees and each side is the same length. 
-   * By default, the first two parameters set the location of the 
-   * upper-left corner, the third sets the width and height. The way 
-   * these parameters are interpreted, however, may be changed with the 
+   * Draws a square to the screen. A square is a four-sided shape with
+   * every angle at ninety degrees and each side is the same length.
+   * By default, the first two parameters set the location of the
+   * upper-left corner, the third sets the width and height. The way
+   * these parameters are interpreted, however, may be changed with the
    * <b>rectMode()</b> function.
    *
    * ( end auto-generated )
@@ -12228,9 +12227,9 @@ public void arc(float a, float b, float c, float d,
   /**
    * ( begin auto-generated from circle.xml )
    *
-   * Draws a circle to the screen. By default, the first two parameters 
-   * set the location of the center, and the third sets the shape's width 
-   * and height. The origin may be changed with the <b>ellipseMode()</b> 
+   * Draws a circle to the screen. By default, the first two parameters
+   * set the location of the center, and the third sets the shape's width
+   * and height. The origin may be changed with the <b>ellipseMode()</b>
    * function.
    *
    * ( end auto-generated )
diff --git a/core/todo.txt b/core/todo.txt
@@ -1,6 +1,11 @@
 0269 (3.5.3)
 
 
+contrib
+X Update missing @Deprecated tags in PApplet.java
+X   https://github.com/processing/processing/pull/5686
+
+
 high-ish
 _ add separator option to loadTable()
 _   https://github.com/processing/processing/issues/5068
diff --git a/todo.txt b/todo.txt
@@ -1,6 +1,10 @@
 0269 (3.5.3)
 
 
+contrib
+X update translation of "sketch" for Russian speakers
+X   https://github.com/processing/processing/pull/5673
+
 _ Find in Reference disabled for various keywords (draw, for, if, catch, while)
 _   https://github.com/processing/processing/issues/5562
 _   https://github.com/processing/processing/pull/5642
