Enable input method support by default on Japanese/Korean/Chinese systems

benfry · benfry · commit 1898f5d1c9d5 · 2016-08-04T10:19:08.000-04:00
diff --git a/app/src/processing/app/Language.java b/app/src/processing/app/Language.java
@@ -236,6 +236,18 @@ static public String getLanguage() {
   }
 
 
+  /**
+   * Is this a CJK language where Input Method support is suggested/required?
+   * @return true if the user is running in Japanese, Korean, or Chinese
+   */
+  static public boolean useInputMethod() {
+    final String language = getLanguage();
+    return (language.equals("ja") ||
+            language.equals("ko") ||
+            language.equals("zh"));
+  }
+
+
 //  /** Set new language (called by Preferences) */
 //  static public void setLanguage(String language) {
 //    this.language = language;
diff --git a/app/src/processing/app/Preferences.java b/app/src/processing/app/Preferences.java
@@ -71,36 +71,18 @@ static public void init() {
                            "You'll need to reinstall Processing.", e);
     }
 
-    /* provisionally removed in 3.0a6, see changes in load()
-
-    // check for platform-specific properties in the defaults
-    String platformExt = "." + PConstants.platformNames[PApplet.platform]; //$NON-NLS-1$
-    int platformExtLength = platformExt.length();
-
-    // Get a list of keys that are specific to this platform
-    ArrayList<String> platformKeys = new ArrayList<String>();
-    for (String key : table.keySet()) {
-      if (key.endsWith(platformExt)) {
-        platformKeys.add(key);
-      }
-    }
-
-    // Use those platform-specific keys to override
-    for (String key : platformKeys) {
-      // this is a key specific to a particular platform
-      String actualKey = key.substring(0, key.length() - platformExtLength);
-      String value = get(key);
-      set(actualKey, value);
-    }
-    */
-
     // Clone the defaults, then override any them with the user's preferences.
     // This ensures that any new/added preference will be present.
     defaults = new HashMap<String, String>(table);
 
     // other things that have to be set explicitly for the defaults
     setColor("run.window.bgcolor", SystemColor.control); //$NON-NLS-1$
 
+    // For CJK users, enable IM support by default
+    if (Language.useInputMethod()) {
+      setBoolean("editor.input_method_support", true);
+    }
+
     // next load user preferences file
     preferencesFile = Base.getSettingsFile(PREFS_FILE);
     boolean firstRun = !preferencesFile.exists();
diff --git a/todo.txt b/todo.txt
@@ -1,4 +1,7 @@
 0252 (3.1.3?)
+X Enable input method support by default on Japanese/Korean/Chinese systems
+X   https://github.com/processing/processing/pull/4598
+
 _ modify line number color when no lines extend that far?
 _   https://github.com/processing/processing/pull/4560
 _ text gutter doesn't seem to be hidpi 
