Skip to content

Commit 12d8251

Browse files
committed
merge fixes for #1400 with updates to #3088
1 parent bd83dea commit 12d8251

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

java/libraries/net/src/processing/net/Client.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ public class Client implements Runnable {
6161
int bufferIndex;
6262
int bufferLast;
6363

64-
boolean isDisposeRegistered = false;
64+
boolean disposeRegistered = false;
65+
6566

6667
/**
6768
* @param parent typically use "this"
@@ -82,7 +83,7 @@ public Client(PApplet parent, String host, int port) {
8283
thread.start();
8384

8485
parent.registerMethod("dispose", this);
85-
isDisposeRegistered = true;
86+
disposeRegistered = true;
8687

8788
// reflection to check whether host sketch has a call for
8889
// public void clientEvent(processing.net.Client)
@@ -160,9 +161,9 @@ public void stop() {
160161
disconnectEventMethod = null;
161162
}
162163
}
163-
if(isDisposeRegistered){
164+
if (disposeRegistered) {
164165
parent.unregisterMethod("dispose", this);
165-
isDisposeRegistered = false;
166+
disposeRegistered = false;
166167
}
167168
dispose();
168169
}

todo.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ X https://github.com/processing/processing/pull/3132
7575
X offer to install libraries imported libraries that are not available
7676
X https://github.com/processing/processing/pull/3155
7777
X https://github.com/processing/processing/issues/2566
78+
X make fatal errors terminate the pde
79+
X https://github.com/processing/processing/issues/3068
80+
X https://github.com/processing/processing/pull/3069
7881

7982
manindra
8083
X Fix for "Probably a ++ should go here" messages
@@ -139,6 +142,9 @@ X https://github.com/processing/processing/pull/3138
139142
X https://github.com/processing/processing/issues/3136
140143
X Display download percentage when fetching contrib info
141144
X https://github.com/processing/processing/pull/3161
145+
X Recreating Client instance will cause an out-of-memory error
146+
X https://github.com/processing/processing/issues/1400
147+
X https://github.com/processing/processing/pull/3088
142148

143149
integration of pdex
144150
X changed JLS4 to JLS8 (but make sure it doesn't introduce anything too weird)

0 commit comments

Comments
 (0)