Fail When Unable to Cache Files

nebhale · nebhale · commit 9786aa3b8949 · 2016-11-28T18:05:56.000-08:00
Previously, when a file could not be cached during offline packaging, a
warning was printed, but the packaging continued without a necessary file.
This is by design for an older requirement that would allow buildpacks to be
created even in the face of networks that prevented access to certain hosts.
In practice, this requirement hasn't been necessary (disabling components is
the preferred way to deal with this) and it is more dangerous to allow a
package build to complete without all of the necessary files.  This change
updates the warning message to be a hard failure of the packaging.
diff --git a/rakelib/dependency_cache_task.rb b/rakelib/dependency_cache_task.rb
@@ -170,8 +170,8 @@ def get_from_cache(configuration, index_configuration, uris)
         pin_version(configuration, found_version.to_s) if ENV['PINNED'].to_b
 
         if found_version.nil?
-          rake_output_message "Unable to resolve version '#{configuration['version']}' for platform " \
-                              "'#{index_configuration[:platform]}'"
+          raise "Unable to resolve version '#{configuration['version']}' for platform " \
+                "'#{index_configuration[:platform]}'"
         end
 
         uris << index[found_version.to_s] unless found_version.nil?
