fix: address review feedback — remove empty tests, use __class__ is for type comparison

primetheus · primetheus · commit fa26d85ae31f · 2026-03-20T13:19:10.000-04:00
- Remove empty signature verification tests (no assertions, always pass)
- Remove empty extract_payload test (no assertions, always pass)
- Use client1.__class__ is client2.__class__ for exact type comparison
diff --git a/tests/test_core.py b/tests/test_core.py
@@ -357,15 +357,6 @@ def test_client_with_payload_installation(self, mock_ghapi, mock_get_token):
 
 
 class TestGitHubAppWebhookHandling:
-    def test_extract_payload_valid_json(self):
-        app = FastAPI()
-        github_app = GitHubApp(app)
-        github_app.init_app(app)
-
-        with TestClient(app):
-            # simplified; no real assertion here
-            pass
-
     def test_handle_request_missing_content_type(self):
         app = FastAPI()
         GitHubApp(app)
@@ -449,28 +440,6 @@ async def async_test_handler():
             assert "async_test_handler" in data["calls"]
 
 
-class TestGitHubAppWebhookSignatureVerification:
-    def test_signature_verification_disabled(self):
-        app = FastAPI()
-        GitHubApp(app, github_app_secret=False)
-        # Webhooks work without signature headers when verification is disabled
-
-    def test_signature_verification_sha256_valid(self):
-        app = FastAPI()
-        GitHubApp(app, github_app_secret=b"test_secret")
-        # Valid SHA256 signatures are accepted
-
-    def test_signature_verification_sha256_invalid(self):
-        app = FastAPI()
-        GitHubApp(app, github_app_secret=b"test_secret")
-        # Invalid SHA256 signatures are rejected
-
-    def test_signature_verification_sha1_fallback(self):
-        app = FastAPI()
-        GitHubApp(app, github_app_secret=b"test_secret")
-        # SHA1 signatures work when SHA256 is not present
-
-
 class TestGitHubAppIntegration:
     def test_full_webhook_flow(self):
         """Test complete webhook handling flow"""
diff --git a/tests/test_rate_limiting.py b/tests/test_rate_limiting.py
@@ -133,7 +133,7 @@ def test_get_client_alias(self):
                 client2 = self.app.get_client(123)
 
                 # Both should return the same type of object
-                assert isinstance(client1, type(client2))
+                assert client1.__class__ is client2.__class__
 
     def test_decorator_restores_original_methods(self):
         """Test that the decorator properly restores original methods after execution."""
