Skip to content

Commit 72d30dd

Browse files
author
MB
committed
[Citrix.com] Add/fix/update comments, fix blogs, add coverage, squish, cosmetics
1 parent cdbbe6a commit 72d30dd

2 files changed

Lines changed: 57 additions & 31 deletions

File tree

‎src/chrome/content/rules/Citrix.com-falsemixed.xml‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<!--
2+
For rules that are on by default, see Citrix.xml.
3+
4+
-->
5+
<ruleset name="Citrix.com (false MCB)" platform="mixedcontent">
6+
7+
<!-- Direct rewrites:
8+
-->
9+
<target host="training.citrix.com" />
10+
11+
12+
<securecookie host="." name="." />
13+
14+
15+
<rule from="^http:"
16+
to="https:" />
17+
18+
</ruleset>

‎src/chrome/content/rules/Citrix.xml‎

Lines changed: 39 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<!--
2-
Commit msg: https://trac.torproject.org/projects/tor/ticket/12800
3-
2+
For rules causing false/broken MCB, see Citrix.com-falsemixed.xml.
43
54
Other Citrix rulesets:
65
@@ -10,34 +9,39 @@
109
- GoToMeeting.com.xml
1110
- GoToTraining.com.xml
1211
- GoToWebinar.com.xml
12+
- Podio.com.xml
1313
- ShareFile.com.xml
1414
- ShareFile_support.com.xml
1515
1616
1717
CDN buckets:
1818
19+
- blogsprod.s3.amazonaws.com
1920
- c558080.r80.cf2.rackcdn.com ← cdn.ws.citrix.com
2021
2122
2223
Nonfunctional domains:
2324
24-
- open.citrix.com Refused
25-
- (www.)joingotomeeting.com
26-
- (www.)jointraining.com
27-
- (www.)joinwebinar.com
28-
25+
- open.citrix.com ¹
26+
- (www.)?joingotomeeting.com ²
27+
- (www.)?jointraining.com ²
28+
- (www.)?joinwebinar.com ²
2929
30-
Problematic domains:
30+
¹ Shows another domain
31+
² Refused
3132
32-
- cdn.ws.citrix.com (akamai)
3333
34+
Problematic hosts in *citrix.com:
3435
35-
Partially covered hosts in *citrix.com:
36+
- blogs ¹
37+
- help ²
38+
- cdn.ws ³
39+
- training ⁴
3640
37-
- discussions *
38-
- training *
39-
40-
* Avoiding broken MCB
41+
¹ Redirects to webapps.citrite.net
42+
² Mismatched
43+
³ Akamai
44+
⁴ Mixed css
4145
4246
4347
Insecure cookies are set for these domains and hosts:
@@ -49,23 +53,21 @@
4953
5054
Mixed content:
5155
52-
- css, on:
53-
54-
- discussions from *.rackcdn.com
55-
- training from $self
56+
- css on training from $self *
5657
5758
- Images, on:
5859
59-
- discussions from $self
60-
- training from www.citrix.com
60+
- training from $self *
61+
- training from www.citrix.com *
62+
63+
* Secured by us
6164
6265
-->
6366
<ruleset name="Citrix.com (partial)">
6467

6568
<!-- Direct rewrites:
6669
-->
6770
<target host="citrix.com" />
68-
<target host="blogs.citrix.com" />
6971
<target host="citrixready.citrix.com" />
7072
<target host="community.citrix.com" />
7173
<target host="discussions.citrix.com" />
@@ -83,39 +85,45 @@
8385

8486
<!-- Complications:
8587
-->
88+
<target host="blogs.citrix.com" />
8689
<target host="cdn.ws.citrix.com" />
8790

8891
<!-- Avoid broken MCB:
8992
-->
90-
<exclusion pattern="^http://discussions\.citrix\.com/+(?!public/)" />
9193
<exclusion pattern="^http://training\.citrix\.com/+(?!favicon\.ico|theme/)" />
9294

9395
<!-- +ve:
9496
-->
95-
<test url="http://discussions.citrix.com/forum/363-storefront/" />
96-
<test url="http://discussions.citrix.com/topic/365473-gssexception/" />
97-
9897
<test url="http://training.citrix.com/cms/education/networking/" />
9998
<test url="http://training.citrix.com/cms/index.php/certification/" />
10099
<test url="http://training.citrix.com/mod/ctxcatalog/training.php?lang=ja" />
101100

102101
<!-- -ve:
103102
-->
104-
105-
<test url="http://discussions.citrix.com/public/style_images/master/attachicon.gif" />
106-
107103
<test url="http://training.citrix.com/favicon.ico" />
108104
<test url="http://training.citrix.com/theme/ctxmain/pix/search_gradient.png" />
109105

106+
<test url="http://discussions.citrix.com/forum/363-storefront/" />
107+
<test url="http://discussions.citrix.com/topic/365473-gssexception/" />
108+
<test url="http://discussions.citrix.com/public/style_images/master/attachicon.gif" />
109+
110110

111111
<!-- Not secured by server:
112112
-->
113-
<!--securecookie host="^\.citrix\.com$" name="^(_wsad_MyCitrixHash|MyCitrixShadow|id_validate)$" /-->
113+
<!--securecookie host="^\.citrix\.com$" name="^(_wsad_|MyCitrixHash|MyCitrixShadow|id_validate)$" /-->
114114
<!--securecookie host="^discussions\.citrix\.com$" name="^session_id$" /-->
115-
<!--securecookie host="^training\.citrix\.com$" name="^(MoodleSession|NSC_\w+_\w+)$" /-->
115+
<!--securecookie host="^training\.citrix\.com$" name="^(MoodleSession$|NSC_)" /-->
116116

117-
<securecookie host="^(?:.*\.)?citrix\.com$" name=".+" />
117+
<securecookie host="." name="." />
118+
119+
120+
<!-- Redirect keeps path and args,
121+
but not forward slash:
122+
-->
123+
<rule from="^http://blogs\.citrix\.com/+"
124+
to="https://www.citrix.com/blogs/" />
118125

126+
<test url="http://blogs.citrix.com//index.htm" />
119127

120128
<rule from="^http://cdn\.ws\.citrix\.com/"
121129
to="https://c558080.ssl.cf2.rackcdn.com/" />

0 commit comments

Comments
 (0)