fix for issue 246

Dmitriy Kunitskiy · Dmitriy Kunitskiy · commit 72b61a81f946 · 2015-07-20T17:25:08.000-07:00
diff --git a/pre_commit/commands/install_uninstall.py b/pre_commit/commands/install_uninstall.py
@@ -27,10 +27,14 @@
 
 
 def is_our_pre_commit(filename):
+    if not os.path.exists(filename):
+        return False
     return IDENTIFYING_HASH in io.open(filename).read()
 
 
 def is_previous_pre_commit(filename):
+    if not os.path.exists(filename):
+        return False
     contents = io.open(filename).read()
     return any(hash in contents for hash in PREVIOUS_IDENTIFYING_HASHES)
 
@@ -53,7 +57,7 @@ def install(runner, overwrite=False, hooks=False, hook_type='pre-commit'):
 
     # If we have an existing hook, move it to pre-commit.legacy
     if (
-        os.path.exists(hook_path) and
+        os.path.lexists(hook_path) and
         not is_our_pre_commit(hook_path) and
         not is_previous_pre_commit(hook_path)
     ):
diff --git a/testing/util.py b/testing/util.py
@@ -73,3 +73,8 @@ def platform_supports_pcre():
     not platform_supports_pcre(),
     reason='grep -P is not supported on this platform',
 )
+
+xfailif_no_symlink = pytest.mark.xfail(
+    not hasattr(os, 'symlink'),
+    reason='Symlink is not supported on this platform',
+)
diff --git a/tests/commands/install_uninstall_test.py b/tests/commands/install_uninstall_test.py
@@ -24,6 +24,7 @@
 from pre_commit.util import resource_filename
 from testing.fixtures import git_dir
 from testing.fixtures import make_consuming_repo
+from testing.util import xfailif_no_symlink
 
 
 def test_is_not_our_pre_commit():
@@ -88,6 +89,15 @@ def test_install_hooks_directory_not_present(tmpdir_factory):
     assert os.path.exists(runner.pre_commit_path)
 
 
+@xfailif_no_symlink
+def test_install_hooks_dead_symlink(tmpdir_factory):
+    path = git_dir(tmpdir_factory)
+    os.symlink('/fake/baz', os.path.join(path, '.git', 'hooks', 'pre-commit'))
+    runner = Runner(path)
+    install(runner)
+    assert os.path.exists(runner.pre_commit_path)
+
+
 def test_uninstall_does_not_blow_up_when_not_there(tmpdir_factory):
     path = git_dir(tmpdir_factory)
     runner = Runner(path)

Original file line number	Diff line number	Diff line change
`@@ -73,3 +73,8 @@ def platform_supports_pcre():`
`73`	`73`	`not platform_supports_pcre(),`
`74`	`74`	`reason='grep -P is not supported on this platform',`
`75`	`75`	`)`
	`76`	`+`
	`77`	`+xfailif_no_symlink = pytest.mark.xfail(`
	`78`	`+ not hasattr(os, 'symlink'),`
	`79`	`+ reason='Symlink is not supported on this platform',`
	`80`	`+)`