Install Rust tools with --locked by default or add a parameter to allow this

search you tried in the issue tracker

rust locked

describe your actual problem

Many (most?) Rust projects come with lock files that specify the exact versions of dependencies with which they are tested. Sometimes, they don't work with newer versions, which is why Cargo offers the --locked parameter to build with the dependency versions specified in the lock files.

Currently, pre-commit installs Rust tools without the --locked parameter. I suggest to use this parameter by default or offer a way to specify that a hook should be built using that parameter.

pre-commit --version

pre-commit 3.6.2

does cargo not use the lock file if present by default? I was under the impression that --locked is only necessary to produce an error if it is missing

does cargo not use the lock file if present by default?

No, the lock file is ignored by default.

hmmmmm I think additional_dependencies: [--locked] will work

No, unfortunately this doesn't seem to work as an @* is added automatically:

An unexpected error has occurred: CalledProcessError: command: ('~/.cargo/bin/cargo', 'add', '--locked@*')
return code: 1
stdout: (none)
stderr:
    error: unexpected argument '--locked@*' found
    
      tip: a similar argument exists: '--locked'
    
    Usage: cargo add [OPTIONS] <DEP>[@<VERSION>] ...
           cargo add [OPTIONS] --path <PATH> ...
           cargo add [OPTIONS] --git <URL> ...
    
    For more information, try '--help'.

Yeah this is a bit awkward. I have resorted to using =1.2.3 style dependencies in my Cargo.toml file, but this isn't a full solution because it doesn't lock transitive dependencies.

allow rust hooks to specify arbitrary cargo install parameters

This issue basically makes it impossible for me to package a linter in a pre-commit hook since to build this linter one has to use locked dependencies, and there is no officially supported way to pull in pre-built binaries, see #1453.

Pre-commit - remove spicy-format

Bump topiary ecosystem

Unbreak building without `--locked` due to prettydiff semver

Unbreak building without `--locked` due to prettydiff semver break

Bump spicy-format

Use `--locked` for Rust `cargo install` commands (#1661)

Navigation Menu

Repository navigation

Install Rust tools with `--locked` by default or add a parameter to allow this #3162

search you tried in the issue tracker

describe your actual problem

pre-commit --version

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Install Rust tools with --locked by default or add a parameter to allow this #3162

Description

search you tried in the issue tracker

describe your actual problem

pre-commit --version

Activity

asottile commented on Mar 21, 2024

mlegner commented on Mar 21, 2024

asottile commented on Mar 21, 2024

mlegner commented on Mar 21, 2024

Timmmm commented on Jul 8, 2024

bbannier commented on Sep 11, 2024

eltos commented on Feb 17, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Install Rust tools with `--locked` by default or add a parameter to allow this #3162