Fix exit code for commands terminated by signals

chriskuehl · chriskuehl · commit 5a4b5b1f8ea2 · 2023-08-21T20:02:27.000-05:00
Fixes #2970
diff --git a/pre_commit/xargs.py b/pre_commit/xargs.py
@@ -170,7 +170,8 @@ def run_cmd_partition(
         results = thread_map(run_cmd_partition, partitions)
 
         for proc_retcode, proc_out, _ in results:
-            retcode = max(retcode, proc_retcode)
+            if abs(proc_retcode) > abs(retcode):
+                retcode = proc_retcode
             stdout += proc_out
 
     return retcode, stdout
diff --git a/tests/xargs_test.py b/tests/xargs_test.py
@@ -147,6 +147,15 @@ def test_xargs_retcode_normal():
     assert ret == 5
 
 
+@pytest.mark.xfail(sys.platform == 'win32', reason='posix only')
+def test_xargs_retcode_killed_by_signal():
+    ret, _ = xargs.xargs(
+        parse_shebang.normalize_cmd(('bash', '-c', 'kill -9 $$', '--')),
+        ('foo', 'bar'),
+    )
+    assert ret == -9
+
+
 def test_xargs_concurrency():
     bash_cmd = parse_shebang.normalize_cmd(('bash', '-c'))
     print_pid = ('sleep 0.5 && echo $$',)
