Merge pull request #1399 from pre-commit/upgrade_pip_on_windows

asottile · web-flow · commit 296054968254 · 2020-04-17T08:21:46.000-07:00
Allow pip to be upgradable on windows
diff --git a/pre_commit/languages/python.py b/pre_commit/languages/python.py
@@ -182,8 +182,8 @@ def install_environment(
             version: str,
             additional_dependencies: Sequence[str],
     ) -> None:
-        additional_dependencies = tuple(additional_dependencies)
         directory = helpers.environment_dir(_dir, version)
+        install = ('python', '-mpip', 'install', '.', *additional_dependencies)
 
         env_dir = prefix.path(directory)
         with clean_path_on_failure(env_dir):
@@ -193,9 +193,7 @@ def install_environment(
                 python = os.path.realpath(sys.executable)
             _make_venv(env_dir, python)
             with in_env(prefix, version):
-                helpers.run_setup_cmd(
-                    prefix, ('pip', 'install', '.') + additional_dependencies,
-                )
+                helpers.run_setup_cmd(prefix, install)
 
     return in_env, healthy, run_hook, install_environment
 
