CLOUDSTACK-3445: Observing the system alerts "unallocated Local Storage is low in cluster" when Primary storage is Local Storage

Koushik Das · Koushik Das · commit 396a13dd0b64 · 2013-07-15T15:20:28.000+05:30
Available bytes was getting stored in the used bytes property of local storage pools. As a result of this, for newly added local pools Cloudstack thinks that there is no space available and generated alerts.
diff --git a/engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java b/engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java
@@ -203,8 +203,8 @@ public long getCapacityBytes() {
         return capacityBytes;
     }
 
-    public void setUsedBytes(long available) {
-        usedBytes = available;
+    public void setUsedBytes(long usedBytes) {
+        this.usedBytes = usedBytes;
     }
 
     public void setCapacityBytes(long capacityBytes) {
diff --git a/engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java b/engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java
@@ -113,7 +113,7 @@ public DataStore attachHost(DataStore store, HostScope scope, StoragePoolInfo ex
 
         StoragePoolVO pool = this.dataStoreDao.findById(store.getId());
         pool.setScope(scope.getScopeType());
-        pool.setUsedBytes(existingInfo.getAvailableBytes());
+        pool.setUsedBytes(existingInfo.getCapacityBytes() - existingInfo.getAvailableBytes());
         pool.setCapacityBytes(existingInfo.getCapacityBytes());
         pool.setStatus(StoragePoolStatus.Up);
         this.dataStoreDao.update(pool.getId(), pool);

Original file line number	Diff line number	Diff line change
`@@ -203,8 +203,8 @@ public long getCapacityBytes() {`
`203`	`203`	`return capacityBytes;`
`204`	`204`	`}`
`205`	`205`
`206`		`- public void setUsedBytes(long available) {`
`207`		`- usedBytes = available;`
	`206`	`+ public void setUsedBytes(long usedBytes) {`
	`207`	`+ this.usedBytes = usedBytes;`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`public void setCapacityBytes(long capacityBytes) {`