fixes

makasim · makasim · commit ccfed5200494 · 2018-09-07T19:03:47.000+03:00
diff --git a/pkg/dbal/Tests/DbalConnectionFactoryConfigTest.php b/pkg/dbal/Tests/DbalConnectionFactoryConfigTest.php
@@ -159,7 +159,7 @@ public static function provideConfigs()
                 'table_name' => 'enqueue',
                 'polling_interval' => 1000,
                 'lazy' => true,
-                'foo' => 'fooVal'
+                'foo' => 'fooVal',
             ],
         ];
     }
diff --git a/pkg/dsn/InvalidQueryParameterTypeException.php b/pkg/dsn/InvalidQueryParameterTypeException.php
@@ -1,4 +1,5 @@
 <?php
+
 namespace Enqueue\Dsn;
 
 final class InvalidQueryParameterTypeException extends \LogicException
@@ -7,4 +8,4 @@ public static function create(string $name, string $expectedType): self
     {
         return new static(sprintf('The query parameter "%s" has invalid type. It must be "%s"', $name, $expectedType));
     }
-}
+}
diff --git a/pkg/enqueue-bundle/DependencyInjection/EnqueueExtension.php b/pkg/enqueue-bundle/DependencyInjection/EnqueueExtension.php
@@ -53,8 +53,8 @@ public function load(array $configs, ContainerBuilder $container): void
                 $config['client']['router_queue'],
                 $config['client']['default_processor_queue'],
                 $config['client']['router_processor'],
-                // todo
-                isset($config['transport']['default']['alias']) ? $config['transport'][$config['transport']['default']['alias']] : [],
+                // @todo should be driver options.
+                $config['transport'],
             ]);
 
             $container->setParameter('enqueue.client.router_queue_name', $config['client']['router_queue']);
diff --git a/pkg/enqueue/Client/Driver/RabbitMqStompDriver.php b/pkg/enqueue/Client/Driver/RabbitMqStompDriver.php
@@ -40,12 +40,6 @@ class RabbitMqStompDriver extends StompDriver
      */
     private $queueMetaRegistry;
 
-    /**
-     * @param StompContext          $context
-     * @param Config                $config
-     * @param QueueMetaRegistry     $queueMetaRegistry
-     * @param StompManagementClient $management
-     */
     public function __construct(StompContext $context, Config $config, QueueMetaRegistry $queueMetaRegistry, StompManagementClient $management)
     {
         parent::__construct($context, $config, $queueMetaRegistry);
diff --git a/pkg/enqueue/Client/DriverFactory.php b/pkg/enqueue/Client/DriverFactory.php
@@ -55,6 +55,10 @@ public function create(PsrConnectionFactory $factory, string $dsn, array $config
                     ));
                 }
 
+                if (false == isset($config['management_plugin_installed'])) {
+                    throw new \LogicException(sprintf('Scheme %s requires the management plugin is to be installed', $dsn->getScheme()));
+                }
+
                 if (isset($config['rabbitmq_management_dsn'])) {
                     $managementDsn = new Dsn($config['rabbitmq_management_dsn']);
 
diff --git a/pkg/enqueue/Client/Resources.php b/pkg/enqueue/Client/Resources.php
@@ -121,7 +121,7 @@ public static function getKnownDrivers(): array
                     'sqlite3',
                     'sqlite',
                 ],
-                'requiredSchemeExtensions' => [],
+                'requiredSchemeExtensions' => ['pdo'],
                 'package' => ['enqueue/enqueue', 'enqueue/dbal'],
             ];
 

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ public static function provideConfigs()`
`159`	`159`	`'table_name' => 'enqueue',`
`160`	`160`	`'polling_interval' => 1000,`
`161`	`161`	`'lazy' => true,`
`162`		`- 'foo' => 'fooVal'`
	`162`	`+ 'foo' => 'fooVal',`
`163`	`163`	`],`
`164`	`164`	`];`
`165`	`165`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`<?php`
	`2`	`+`
`2`	`3`	`namespace Enqueue\Dsn;`
`3`	`4`
`4`	`5`	`final class InvalidQueryParameterTypeException extends \LogicException`
`@@ -7,4 +8,4 @@ public static function create(string $name, string $expectedType): self`
`7`	`8`	`{`
`8`	`9`	`return new static(sprintf('The query parameter "%s" has invalid type. It must be "%s"', $name, $expectedType));`
`9`	`10`	`}`
`10`		`-}`
	`11`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,10 @@ public function create(PsrConnectionFactory $factory, string $dsn, array $config`
`55`	`55`	`));`
`56`	`56`	`}`
`57`	`57`
	`58`	`+ if (false == isset($config['management_plugin_installed'])) {`
	`59`	`+ throw new \LogicException(sprintf('Scheme %s requires the management plugin is to be installed', $dsn->getScheme()));`
	`60`	`+ }`
	`61`	`+`
`58`	`62`	`if (isset($config['rabbitmq_management_dsn'])) {`
`59`	`63`	`$managementDsn = new Dsn($config['rabbitmq_management_dsn']);`
`60`	`64`