fix tests.

makasim · makasim · commit 95973d3f36e7 · 2018-01-17T17:04:41.000+02:00
diff --git a/pkg/dbal/Tests/DbalConnectionFactoryConfigTest.php b/pkg/dbal/Tests/DbalConnectionFactoryConfigTest.php
@@ -47,64 +47,83 @@ public function testShouldParseConfigurationAsExpected($config, $expectedConfig)
     {
         $factory = new DbalConnectionFactory($config);
 
-        $this->assertAttributeEquals($expectedConfig, 'config', $factory);
+        $actualConfig = $this->readAttribute($factory, 'config');
+        $this->assertSame($expectedConfig, $actualConfig);
     }
 
     public static function provideConfigs()
     {
         yield [
             null,
             [
-                'lazy' => true,
                 'connection' => [
                     'url' => 'mysql://root@localhost',
                 ],
+                'table_name' => 'enqueue',
+                'polling_interval' => 1000,
+                'lazy' => true,
             ],
         ];
 
         yield [
             'mysql:',
             [
-                'lazy' => true,
                 'connection' => [
                     'url' => 'mysql://root@localhost',
                 ],
+                'table_name' => 'enqueue',
+                'polling_interval' => 1000,
+                'lazy' => true,
             ],
         ];
 
         yield [
             'pgsql:',
             [
-                'lazy' => true,
                 'connection' => [
                     'url' => 'pgsql://root@localhost',
                 ],
+                'table_name' => 'enqueue',
+                'polling_interval' => 1000,
+                'lazy' => true,
             ],
         ];
 
         yield [
             'mysql://user:pass@host:10000/db',
             [
-                'lazy' => true,
                 'connection' => [
                     'url' => 'mysql://user:pass@host:10000/db',
                 ],
+                'table_name' => 'enqueue',
+                'polling_interval' => 1000,
+                'lazy' => true,
             ],
         ];
 
         yield [
             [],
             [
-                'lazy' => true,
                 'connection' => [
                     'url' => 'mysql://root@localhost',
                 ],
+                'table_name' => 'enqueue',
+                'polling_interval' => 1000,
+                'lazy' => true,
             ],
         ];
 
         yield [
-            ['table_name' => 'a_queue_table', 'connection' => ['foo' => 'fooVal', 'bar' => 'barVal']],
-            ['table_name' => 'a_queue_table', 'connection' => ['foo' => 'fooVal', 'bar' => 'barVal']],
+            [
+                'connection' => ['foo' => 'fooVal', 'bar' => 'barVal'],
+                'table_name' => 'a_queue_table',
+            ],
+            [
+                'connection' => ['foo' => 'fooVal', 'bar' => 'barVal'],
+                'table_name' => 'a_queue_table',
+                'polling_interval' => 1000,
+                'lazy' => true,
+            ],
         ];
     }
 }
diff --git a/pkg/dbal/Tests/DbalConnectionFactoryTest.php b/pkg/dbal/Tests/DbalConnectionFactoryTest.php
@@ -2,7 +2,6 @@
 
 namespace Enqueue\Dbal\Tests;
 
-use Doctrine\DBAL\Connection;
 use Enqueue\Dbal\DbalConnectionFactory;
 use Enqueue\Dbal\DbalContext;
 use Enqueue\Test\ClassExtensionTrait;
@@ -17,33 +16,6 @@ public function testShouldImplementConnectionFactoryInterface()
         $this->assertClassImplements(PsrConnectionFactory::class, DbalConnectionFactory::class);
     }
 
-    public function testCouldBeConstructedWithEmptyConfiguration()
-    {
-        $factory = new DbalConnectionFactory();
-
-        $this->assertAttributeEquals([
-            'lazy' => true,
-            'connection' => ['url' => 'mysql://root@localhost'],
-        ], 'config', $factory);
-    }
-
-    public function testCouldBeConstructedWithCustomConfiguration()
-    {
-        $factory = new DbalConnectionFactory([
-            'connection' => [
-                'dbname' => 'theDbName',
-            ],
-            'lazy' => false,
-        ]);
-
-        $this->assertAttributeEquals([
-            'lazy' => false,
-            'connection' => [
-                'dbname' => 'theDbName',
-            ],
-        ], 'config', $factory);
-    }
-
     public function testShouldCreateLazyContext()
     {
         $factory = new DbalConnectionFactory(['lazy' => true]);
