ResetServicesExtension to run _after_ message received

David Marland · David Marland · commit 78282ae704aa · 2021-05-24T12:09:44.000+01:00
Resolves php-enqueue#1156 Reset the services after message is received, so that logs are flushed without having to wait for a new message
diff --git a/pkg/enqueue-bundle/Consumption/Extension/ResetServicesExtension.php b/pkg/enqueue-bundle/Consumption/Extension/ResetServicesExtension.php
@@ -2,11 +2,11 @@
 
 namespace Enqueue\Bundle\Consumption\Extension;
 
-use Enqueue\Consumption\Context\MessageReceived;
-use Enqueue\Consumption\MessageReceivedExtensionInterface;
+use Enqueue\Consumption\Context\PostMessageReceived;
+use Enqueue\Consumption\PostMessageReceivedExtensionInterface;
 use Symfony\Component\HttpKernel\DependencyInjection\ServicesResetter;
 
-class ResetServicesExtension implements MessageReceivedExtensionInterface
+class ResetServicesExtension implements PostMessageReceivedExtensionInterface
 {
     /**
      * @var ServicesResetter
@@ -18,7 +18,7 @@ public function __construct(ServicesResetter $resetter)
         $this->resetter = $resetter;
     }
 
-    public function onMessageReceived(MessageReceived $context): void
+    public function onPostMessageReceived(PostMessageReceived $context): void
     {
         $context->getLogger()->debug('[ResetServicesExtension] Resetting services.');
 
diff --git a/pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/ResetServicesExtensionTest.php b/pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/ResetServicesExtensionTest.php
@@ -37,7 +37,7 @@ public function testItShouldResetServices()
         ;
 
         $extension = new ResetServicesExtension($resetter);
-        $extension->onMessageReceived($context);
+        $extension->onPostMessageReceived($context);
     }
 
     protected function createContext(): MessageReceived

Original file line number	Diff line number	Diff line change
`@@ -2,11 +2,11 @@`
`2`	`2`
`3`	`3`	`namespace Enqueue\Bundle\Consumption\Extension;`
`4`	`4`
`5`		`-use Enqueue\Consumption\Context\MessageReceived;`
`6`		`-use Enqueue\Consumption\MessageReceivedExtensionInterface;`
	`5`	`+use Enqueue\Consumption\Context\PostMessageReceived;`
	`6`	`+use Enqueue\Consumption\PostMessageReceivedExtensionInterface;`
`7`	`7`	`use Symfony\Component\HttpKernel\DependencyInjection\ServicesResetter;`
`8`	`8`
`9`		`-class ResetServicesExtension implements MessageReceivedExtensionInterface`
	`9`	`+class ResetServicesExtension implements PostMessageReceivedExtensionInterface`
`10`	`10`	`{`
`11`	`11`	`/**`
`12`	`12`	`* @var ServicesResetter`
`@@ -18,7 +18,7 @@ public function __construct(ServicesResetter $resetter)`
`18`	`18`	`$this->resetter = $resetter;`
`19`	`19`	`}`
`20`	`20`
`21`		`- public function onMessageReceived(MessageReceived $context): void`
	`21`	`+ public function onPostMessageReceived(PostMessageReceived $context): void`
`22`	`22`	`{`
`23`	`23`	`$context->getLogger()->debug('[ResetServicesExtension] Resetting services.');`
`24`	`24`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function testItShouldResetServices()`
`37`	`37`	`;`
`38`	`38`
`39`	`39`	`$extension = new ResetServicesExtension($resetter);`
`40`		`- $extension->onMessageReceived($context);`
	`40`	`+ $extension->onPostMessageReceived($context);`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`protected function createContext(): MessageReceived`