Remove extra AppVeyor environment check (PowerShell#8709)

RDIL · TravisEz13 · commit 3ab7e2ec4d75 · 2019-02-08T10:57:41.000-08:00
Removes a check for AppVeyor env ## PR Context AppVeyor removed (PowerShell#8686 extension)
diff --git a/test/packaging/windows/msi.tests.ps1 b/test/packaging/windows/msi.tests.ps1
@@ -74,13 +74,9 @@ Describe -Name "Windows MSI" -Fixture {
     }
     AfterEach {
         if ($Error.Count -ne 0 -and !$uploadedLog) {
-            if ($env:APPVEYOR) {
-                Push-AppveyorArtifact $msiLog
-            } else {
-                Copy-Item -Path $msiLog -Destination $env:temp -Force
-                Write-Verbose "MSI log is at $env:temp\msilog.txt" -Verbose
-            }
-            $uploadedLog = $true
+            Copy-Item -Path $msiLog -Destination $env:temp -Force
+            Write-Verbose "MSI log is at $env:temp\msilog.txt" -Verbose
+            $uploadedLog = $true 
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -74,13 +74,9 @@ Describe -Name "Windows MSI" -Fixture {`
`74`	`74`	`}`
`75`	`75`	`AfterEach {`
`76`	`76`	`if ($Error.Count -ne 0 -and !$uploadedLog) {`
`77`		`- if ($env:APPVEYOR) {`
`78`		`- Push-AppveyorArtifact $msiLog`
`79`		`- } else {`
`80`		`- Copy-Item -Path $msiLog -Destination $env:temp -Force`
`81`		`- Write-Verbose "MSI log is at $env:temp\msilog.txt" -Verbose`
`82`		`- }`
`83`		`- $uploadedLog = $true`
	`77`	`+ Copy-Item -Path $msiLog -Destination $env:temp -Force`
	`78`	`+ Write-Verbose "MSI log is at $env:temp\msilog.txt" -Verbose`
	`79`	`+ $uploadedLog = $true`
`84`	`80`	`}`
`85`	`81`	`}`
`86`	`82`