[Feature] Address Steve's new comments

daxian-dbw · daxian-dbw · commit 01ecf4b3d383 · 2018-01-08T09:54:28.000-08:00
diff --git a/src/System.Management.Automation/engine/PSConfiguration.cs b/src/System.Management.Automation/engine/PSConfiguration.cs
@@ -498,7 +498,7 @@ private void RemoveValueFromFile<T>(string fileName, string key)
 
     /// <summary>
     /// The GroupPolicy related settings used in PowerShell are as follows in Registry:
-    ///  - Software\Policies\Microsoft\Windows\PowerShell -- { EnableScripts (0 or 1); ExecutionPolicy (string) }
+    ///  - Software\Policies\Microsoft\PowerShellCore -- { EnableScripts (0 or 1); ExecutionPolicy (string) }
     ///      SubKeys                  Name-Value-Pairs
     ///      - ScriptBlockLogging     { EnableScriptBlockLogging (0 or 1); EnableScriptBlockInvocationLogging (0 or 1) }
     ///      - ModuleLogging          { EnableModuleLogging (0 or 1); ModuleNames (string[]) }
@@ -528,10 +528,10 @@ private void RemoveValueFromFile<T>(string fileName, string key)
     ///     "Transcription": {
     ///       "EnableTranscripting": true,
     ///       "EnableInvocationHeader": true,
-    ///       "OutputDirectory": "c:\tmp"
+    ///       "OutputDirectory": "c:\\tmp"
     ///     },
     ///     "UpdatableHelp": {
-    ///       "DefaultSourcePath": "f:\temp"
+    ///       "DefaultSourcePath": "f:\\temp"
     ///     },
     ///     "ConsoleSessionConfiguration": {
     ///       "EnableConsoleSessionConfiguration": true,
diff --git a/src/System.Management.Automation/engine/Utils.cs b/src/System.Management.Automation/engine/Utils.cs
@@ -551,7 +551,7 @@ internal static bool IsValidPSEditionValue(string editionValue)
                         case nameof(Transcription):               result = policies.Transcription; break;
                         case nameof(UpdatableHelp):               result = policies.UpdatableHelp; break;
                         case nameof(ConsoleSessionConfiguration): result = policies.ConsoleSessionConfiguration; break;
-                        default: Diagnostics.Assert(false, "Unreachable code"); break;
+                        default: Diagnostics.Assert(false, "Should be unreachable code. Update this switch block when new PowerShell policy types are added."); break;
                     }
                     if (result != null) { return (T) result; }
                 }

Original file line number	Diff line number	Diff line change
`@@ -551,7 +551,7 @@ internal static bool IsValidPSEditionValue(string editionValue)`
`551`	`551`	`case nameof(Transcription): result = policies.Transcription; break;`
`552`	`552`	`case nameof(UpdatableHelp): result = policies.UpdatableHelp; break;`
`553`	`553`	`case nameof(ConsoleSessionConfiguration): result = policies.ConsoleSessionConfiguration; break;`
`554`		`- default: Diagnostics.Assert(false, "Unreachable code"); break;`
	`554`	`+ default: Diagnostics.Assert(false, "Should be unreachable code. Update this switch block when new PowerShell policy types are added."); break;`
`555`	`555`	`}`
`556`	`556`	`if (result != null) { return (T) result; }`
`557`	`557`	`}`