Fix Github Actions versioned image push (feast-dev#994)

mrzzy · web-flow · commit 239e1915f1b6 · 2020-09-10T17:45:00.000+08:00
* Fix push semver versioned ci image not being pushed if has semver suffix.

* Add comments to document semver regex.

* Replace regular expression matcher with grep -P for Perl regex style matching.
diff --git a/.github/workflows/master_only.yml b/.github/workflows/master_only.yml
@@ -42,8 +42,10 @@ jobs:
       - name: Push versioned release
         run: |
           # Build and push semver tagged commits
-          rx='^v[0-9]+?\.[0-9]+?\.[0-9]+?$'
-          if [[ "${RELEASE_VERSION}" =~ $rx ]]; then
+          # Regular expression should match MAJOR.MINOR.PATCH[-PRERELEASE[.IDENTIFIER]]
+          # eg. v0.7.1 v0.7.2-alpha v0.7.2-rc.1
+          rx='^v([0-9]+)\.([0-9]+)\.([0-9]+)(?:-([0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*))$ '
+          if echo "${RELEASE_VERSION}" | grep -P "$rx" &>/dev/null ; then
             VERSION_WITHOUT_PREFIX=${RELEASE_VERSION:1}
 
             docker tag gcr.io/kf-feast/feast-${{ matrix.component }}:${GITHUB_SHA} gcr.io/kf-feast/feast-${{ matrix.component }}:${VERSION_WITHOUT_PREFIX}
