Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: frozenfung/hypernova-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: polydice/hypernova-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 16 files changed
  • 9 contributors

Commits on Jan 13, 2017

  1. Run CI on Ruby 2.3 as well

    @dlackty
    dlackty committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    091fb31 View commit details
    Browse the repository at this point in the history

  2. Merge pull request airbnb#10 from dlackty/patch-1 

    Run CI on Ruby 2.3 as well
    @ljharb
    ljharb authored Jan 13, 2017
    Configuration menu
    Copy the full SHA
    cc23523 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2017

  1. [dev] display stack trace in monospace 

    Babel and other compilers omit nice error messages, but those messages
rely on the pre-wrap spacing behavior of a monospaced terminal.

This commit changes the development mode plugin to emit stacks in a
pre-like block.

![screenshot](https://monosnap.com/file/LmjcxybFXp1mPCHNS7QMZNNgGDfwO3.png)
    Jake Teton-Landis
    Jake Teton-Landis committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    f031dff View commit details
    Browse the repository at this point in the history

  2. [spec] fix unrelated WebMock spec failure 

    Loosten the specificity of the WebMock request being stubbed here; the
stub message was generated by webmock and copy-pasted into Rspec, which
worked for Faraday 0.10. Faraday 0.11 generated different, even more
detailed headers.

But are we really testing the specifc headers of Faraday here? No. it
doesn't matter at all.

This commit removes the over-specificity of this stub_request call to
reduce these sorts of spurious failures.
    Jake Teton-Landis
    Jake Teton-Landis committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    dc94323 View commit details
    Browse the repository at this point in the history

  3. Merge pull request airbnb#11 from justjake/jake--monospace-stack-trace 

    [dev] display stack trace in monospace
    @goatslacker
    goatslacker authored Feb 9, 2017
    Configuration menu
    Copy the full SHA
    111183a View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md for airbnb#11 

    From airbnb#11:

> Babel and other compilers omit nice error messages, but those messages
> rely on the pre-wrap spacing behavior of a monospaced terminal.

> This commit changes the development mode plugin to emit stacks in a
> pre-like block. It also html_escapes the stack trace to prevent strange
> rendering errors that sometimes occur if the error contains <html>.
    @justjake
    justjake authored Feb 9, 2017
    Configuration menu
    Copy the full SHA
    9fada5b View commit details
    Browse the repository at this point in the history

  5. Merge pull request airbnb#12 from justjake/patch-1 

    Update CHANGELOG.md for airbnb#11
    @ljharb
    ljharb authored Feb 9, 2017
    Configuration menu
    Copy the full SHA
    14c6a2f View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2017

  1. Version 1.2.0

    @goatslacker
    goatslacker committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    7614f8f View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2017

  1. Pass hash into on_error

    Gil Birman
    Gil Birman committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    aecc462 View commit details
    Browse the repository at this point in the history

  2. fix plugin_helper.rb and pass in nil instead of {}

    Gil Birman
    Gil Birman committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    d9691fb View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2017

  1. fix failing spec

    Gil Birman
    Gil Birman committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    c5dbe83 View commit details
    Browse the repository at this point in the history

  2. Merge pull request airbnb#18 from gilbox/gil--on_error-args 

    Pass hash into on_error
    @goatslacker
    goatslacker authored Jul 28, 2017
    Configuration menu
    Copy the full SHA
    e65ff7c View commit details
    Browse the repository at this point in the history

  3. Version 1.3.0

    @goatslacker
    goatslacker committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    cdee4f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. fix: render_batch receives jobs in hash form. 

    All occurrences of RequestService's `render_batch` receive their jobs input
in hash form but were expecting it to be an array.
This caused the on_error callbacks to always silently get called with a
nil job.

Since the consistent form of arguments to the RequestService's methods is a hash,
the mock jobs in its test are also wrapped in a hash ( instead of an
array ).
    Dimitris Bachtis
    Dimitris Bachtis committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    6906901 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. Merge pull request airbnb#21 from 0xdiba/send_job_info_on_error 

    fix: render_batch receives jobs in hash form.
    @goatslacker
    goatslacker authored Jan 15, 2019
    Configuration menu
    Copy the full SHA
    9fa2a7f View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Version 1.4.0

    @goatslacker
    goatslacker committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    ce24970 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. make hypernova request async

    @atitan
    atitan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    6b96d0b View commit details
    Browse the repository at this point in the history
Loading