Skip to content

Commit fc8c3c6

Browse files
author
Jon M. Mease
committed
Some cleanup of createDeltaObject.
Doesn't look like there's a straightforward lodash equivalent so we'll leave it as is
1 parent dcb1cbc commit fc8c3c6

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

js/src/Figure.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1670,11 +1670,6 @@ function performRemoveProps(parentObj, keyPaths) {
16701670
* @param {Object} fullObj
16711671
* @param {Object} removeObj
16721672
*
1673-
* TODO: investigate replacing with lodash's mergeWith and a customizer
1674-
* that nulls out identical properties
1675-
*
1676-
* Would also need a recursive null property unsetter
1677-
*
16781673
* Examples:
16791674
*
16801675
*/
@@ -1702,7 +1697,7 @@ function createDeltaObject (fullObj, removeObj) {
17021697
) {
17031698
// Compute object equality
17041699
var props_equal;
1705-
props_equal = _.isEqual(removeObj[p], fullObj[p]);
1700+
props_equal = _.isEqual(fullObj[p], removeObj[p]);
17061701

17071702
// Perform recursive comparison if props are not equal
17081703
if (!props_equal || p === 'uid') { // Let uids through

0 commit comments

Comments
 (0)