Move esbuild configs to one file, update references

camdecoster · camdecoster · commit dbe27dffa2d2 · 2025-10-15T15:15:28.000-06:00
diff --git a/biome.json b/biome.json
@@ -4,6 +4,7 @@
   "files": {
     "maxSize": 10000000,
     "includes": [
+      "**/esbuild-config.js",
       "**/src/**",
       "**/lib/**",
       "**/test/**",
diff --git a/devtools/regl_codegen/server.mjs b/devtools/regl_codegen/server.mjs
@@ -7,7 +7,7 @@ import minimist from 'minimist';
 
 import constants from '../../tasks/util/constants.js';
 import { build } from 'esbuild';
-import config from '../../esbuild-config.js';
+import { esbuildConfig as config } from '../../esbuild-config.js';
 
 var args = minimist(process.argv.slice(2), {});
 var PORT = args.port || 3000;
@@ -64,11 +64,6 @@ server.listen(PORT);
 // open up browser window
 open('http://localhost:' + PORT + '/devtools/regl_codegen/index' + (strict ? '-strict' : '') + '.html');
 
-var devtoolsPath = path.join(constants.pathToRoot, 'devtools/regl_codegen');
-config.entryPoints = [path.join(devtoolsPath, 'devtools.js')];
-config.outfile = './build/regl_codegen-bundle.js';
-config.sourcemap = false;
-config.minify = false;
 await build(config);
 
 function getMockFiles() {
diff --git a/devtools/test_dashboard/server.mjs b/devtools/test_dashboard/server.mjs
@@ -7,51 +7,25 @@ import minimist from 'minimist';
 
 import constants from '../../tasks/util/constants.js';
 import { context, build } from 'esbuild';
-import config from '../../esbuild-config.js';
 
-import { glsl } from 'esbuild-plugin-glsl';
+import { devtoolsConfig, localDevConfig } from '../../esbuild-config.js';
 
 var args = minimist(process.argv.slice(2), {});
 var PORT = args.port || 3000;
 var strict = args.strict;
 var mathjax3 = args.mathjax3;
 var mathjax3chtml = args.mathjax3chtml;
 
-if (strict) {
-    config.entryPoints = ['./lib/index-strict.js'];
-}
-
-config.outfile = './build/plotly.js';
+if (strict) localDevConfig.entryPoints = ['./lib/index-strict.js'];
 
 var mockFolder = constants.pathToTestImageMocks;
 
 // mock list
 await getMockFiles().then(readFiles).then(createMocksList).then(saveMockListToFile);
 
-// Devtools config
-var devtoolsConfig = {
-    entryPoints: [path.join(constants.pathToRoot, 'devtools', 'test_dashboard', 'devtools.js')],
-    outfile: path.join(constants.pathToRoot, 'build', 'test_dashboard-bundle.js'),
-    format: 'cjs',
-    globalName: 'Tabs',
-    bundle: true,
-    minify: false,
-    sourcemap: false,
-    plugins: [
-        glsl({
-            minify: true
-        })
-    ],
-    define: {
-        global: 'window'
-    },
-    target: 'es2016',
-    logLevel: 'info'
-};
-
 build(devtoolsConfig);
 
-var ctx = await context(config);
+var ctx = await context(localDevConfig);
 devServer();
 console.log('watching esbuild...');
 await ctx.watch();
diff --git a/esbuild-config.js b/esbuild-config.js
@@ -1,30 +1,59 @@
-var glsl = require('esbuild-plugin-glsl').glsl;
-var environmentPlugin = require('esbuild-plugin-environment').environmentPlugin;
+const { environmentPlugin } = require('esbuild-plugin-environment');
+const { glsl } = require('esbuild-plugin-glsl');
 const InlineCSSPlugin = require('esbuild-plugin-inline-css');
+const path = require('path');
+const constants = require('./tasks/util/constants.js');
 
-module.exports = {
+// Default config used when building library
+const esbuildConfig = {
     entryPoints: ['./lib/index.js'],
     format: 'iife',
     globalName: 'Plotly',
     bundle: true,
     minify: false,
     sourcemap: false,
-    plugins: [
-        InlineCSSPlugin(),
-        glsl({
-            minify: true,
-        }),
-        environmentPlugin({
-            NODE_DEBUG: false,
-        }),
-    ],
+    plugins: [InlineCSSPlugin(), glsl({ minify: true }), environmentPlugin({ NODE_DEBUG: false })],
     alias: {
-        stream: 'stream-browserify',
+        stream: 'stream-browserify'
     },
     define: {
         global: 'window',
-        'define.amd': 'false',
+        'define.amd': 'false'
     },
     target: 'es2016',
-    logLevel: 'info',
+    logLevel: 'info'
+};
+
+const devtoolsConfig = {
+    entryPoints: [path.join(constants.pathToRoot, 'devtools', 'test_dashboard', 'devtools.js')],
+    outfile: path.join(constants.pathToRoot, 'build', 'test_dashboard-bundle.js'),
+    format: 'cjs',
+    globalName: 'Tabs',
+    bundle: true,
+    minify: false,
+    sourcemap: false,
+    plugins: [glsl({ minify: true })],
+    define: { global: 'window' },
+    target: 'es2016',
+    logLevel: 'info'
+};
+
+const localDevConfig = {
+    ...esbuildConfig,
+    outfile: './build/plotly.js'
+};
+
+const localDevReglCodegenConfig = {
+    ...esbuildConfig,
+    entryPoints: [path.join(constants.pathToRoot, 'devtools/regl_codegen', 'devtools.js')],
+    outfile: './build/regl_codegen-bundle.js',
+    sourcemap: false,
+    minify: false
+};
+
+module.exports = {
+    devtoolsConfig,
+    esbuildConfig,
+    localDevConfig,
+    localDevReglCodegenConfig,
 };
diff --git a/tasks/util/bundle_wrapper.mjs b/tasks/util/bundle_wrapper.mjs
@@ -4,7 +4,7 @@ import prependFile from 'prepend-file';
 
 import { build } from 'esbuild';
 
-import esbuildConfig from '../../esbuild-config.js';
+import { esbuildConfig } from '../../esbuild-config.js';
 import esbuildPluginStripMeta from '../../tasks/compress_attributes.js';
 
 import common from './common.js';
diff --git a/test/jasmine/karma.conf.js b/test/jasmine/karma.conf.js
@@ -3,7 +3,7 @@
 var path = require('path');
 var minimist = require('minimist');
 var constants = require('../../tasks/util/constants');
-var esbuildConfig = require('../../esbuild-config.js');
+const { esbuildConfig } = require('../../esbuild-config.js');
 
 var isCI = Boolean(process.env.CI);
 
