use esbuild with karma and jasmine

archmoj · archmoj · commit 13c9a5ecc8fc · 2024-02-28T12:28:40.000-05:00
diff --git a/devtools/regl_codegen/server.mjs b/devtools/regl_codegen/server.mjs
@@ -7,7 +7,7 @@ import minimist from 'minimist';
 
 import constants from '../../tasks/util/constants.js';
 import { build } from 'esbuild';
-import config from '../../esbuild-config.mjs';
+import config from '../../esbuild-config.js';
 
 var args = minimist(process.argv.slice(2), {});
 var PORT = args.port || 3000;
diff --git a/devtools/test_dashboard/server.mjs b/devtools/test_dashboard/server.mjs
@@ -7,7 +7,7 @@ import minimist from 'minimist';
 
 import constants from '../../tasks/util/constants.js';
 import { context } from 'esbuild';
-import config from '../../esbuild-config.mjs';
+import config from '../../esbuild-config.js';
 
 var args = minimist(process.argv.slice(2), {});
 var PORT = args.port || 3000;
@@ -19,6 +19,8 @@ if(strict) {
     config.entryPoints = ['./lib/index-strict.js'];
 }
 
+config.outfile = './build/plotly.js';
+
 var mockFolder = constants.pathToTestImageMocks;
 
 // mock list
diff --git a/esbuild-config.js b/esbuild-config.js
@@ -1,10 +1,9 @@
-import { glsl } from 'esbuild-plugin-glsl';
-import { environmentPlugin } from 'esbuild-plugin-environment';
-// import babel from 'esbuild-plugin-babel';
+var glsl = require('esbuild-plugin-glsl').glsl;
+var environmentPlugin = require('esbuild-plugin-environment').environmentPlugin;
+// var babel = require('esbuild-plugin-babel');
 
-export default {
+module.exports = {
     entryPoints: ['./lib/index.js'],
-    outfile: './build/plotly.js',
     format: 'iife',
     globalName: 'Plotly',
     bundle: true,
diff --git a/tasks/util/bundle_wrapper.mjs b/tasks/util/bundle_wrapper.mjs
@@ -1,6 +1,6 @@
 import { build } from 'esbuild';
 
-import esbuildConfig from '../../esbuild-config.mjs';
+import esbuildConfig from '../../esbuild-config.js';
 import browserifyAdapter from 'esbuild-plugin-browserify-adapter';
 
 import transform from '../../tasks/compress_attributes.js';
diff --git a/test/jasmine/karma.conf.js b/test/jasmine/karma.conf.js
@@ -2,10 +2,8 @@
 
 var path = require('path');
 var minimist = require('minimist');
-var NodePolyfillPlugin = require('node-polyfill-webpack-plugin');
-var LoaderOptionsPlugin = require('webpack').LoaderOptionsPlugin;
 var constants = require('../../tasks/util/constants');
-var webpackConfig = require('../../webpack.config.js');
+var esbuildConfig = require('../../esbuild-config.js');
 
 var isCI = Boolean(process.env.CI);
 
@@ -175,9 +173,17 @@ func.defaultConfig = {
     // base path that will be used to resolve all patterns (eg. files, exclude)
     basePath: constants.pathToRoot,
 
-    // frameworks to use
-    // available frameworks: https://npmjs.org/browse/keyword/karma-adapter
-    frameworks: ['jasmine', 'jasmine-spec-tags', 'webpack', 'viewport'],
+    frameworks: ['jasmine', 'jasmine-spec-tags', 'viewport'],
+
+    plugins: [
+        require('karma-jasmine'),
+        require('karma-jasmine-spec-tags'),
+        require('karma-viewport'),
+        require('karma-spec-reporter'),
+        require('karma-chrome-launcher'),
+        require('karma-firefox-launcher'),
+        require('karma-esbuild'),
+    ],
 
     // list of files / patterns to load in the browser
     //
@@ -262,26 +268,7 @@ func.defaultConfig = {
         }
     },
 
-    webpack: {
-        target: ['web', 'es5'],
-        module: {
-            rules: webpackConfig.module.rules
-        },
-        resolve: {
-            fallback: {
-                stream: require.resolve('stream-browserify')
-            }
-        },
-        plugins: [
-            new NodePolyfillPlugin({ includeAliases: ['process'] }),
-            new LoaderOptionsPlugin({
-                // test: /\.xxx$/, // may apply this only for some modules
-                options: {
-                    library: webpackConfig.output.library
-                }
-            })
-        ]
-    },
+    esbuild: esbuildConfig,
 
     client: {
         // Options for `karma-jasmine-spec-tags`
@@ -328,21 +315,13 @@ func.defaultConfig = {
     failOnEmptyTestSuite: !argv.doNotFailOnEmptyTestSuite
 };
 
-func.defaultConfig.preprocessors[pathToCustomMatchers] = ['webpack'];
-func.defaultConfig.preprocessors[testFileGlob] = ['webpack'];
+func.defaultConfig.preprocessors[pathToCustomMatchers] = ['esbuild'];
+func.defaultConfig.preprocessors[testFileGlob] = ['esbuild'];
 
 if(isBundleTest) {
     switch(basename(testFileGlob)) {
         case 'minified_bundle':
             func.defaultConfig.files.push(constants.pathToPlotlyBuildMin);
-            func.defaultConfig.module = {
-                rules: {
-                    test: /\.js$/,
-                    use: [
-                        'transform-loader?' + path.resolve(__dirname, 'tasks/compress_attributes.js')
-                    ]
-                }
-            };
             break;
         case 'plotschema':
             // no tasks/compress_attributes in this case
