Skip to content

Commit dcdcd81

Browse files
gjtorikiannightwing
authored andcommitted
Fix it up
1 parent b132200 commit dcdcd81

2 files changed

Lines changed: 6 additions & 20 deletions

File tree

lib/ace/autocomplete.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,8 @@ var Autocomplete = function() {
193193
var max = this.popup.session.getLength() - 1;
194194

195195
var choices = this.popup.container.getElementsByClassName("ace_text-layer")[0].childNodes;
196-
dom.removeCssClass(choices[row], "autocomplete_selected");
196+
if (choices[row])
197+
dom.removeCssClass(choices[row], "autocomplete_selected");
197198

198199
switch(where) {
199200
case "up": row = row < 0 ? max : row-1; break;
@@ -202,7 +203,8 @@ var Autocomplete = function() {
202203
case "end": row = max; break
203204
}
204205

205-
dom.addCssClass(choices[row], "autocomplete_selected");
206+
if (choices[row])
207+
dom.addCssClass(choices[row], "autocomplete_selected");
206208
this.popup.setRow(row);
207209
};
208210

@@ -326,7 +328,7 @@ var Autocomplete = function() {
326328

327329
//var MultiSelect = require("ace/multi_select").MultiSelect;
328330
//new MultiSelect(editor);
329-
editor.session.setUndoManager(new UndoManager());
331+
//editor.session.setUndoManager(new UndoManager());
330332

331333
editor.setHighlightActiveLine(false);
332334
editor.setShowPrintMargin(false);

lib/ace/editor.js

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ var Editor = function(renderer, session) {
9090
});
9191

9292
this.setSession(session || new EditSession(""));
93-
this.autocomplete = new Autocomplete(this);
93+
Autocomplete.addTo(this);
9494
config.resetOptions(this);
9595
config._emit("editor", this);
9696
};
@@ -473,26 +473,10 @@ var Editor = function(renderer, session) {
473473

474474
this._emit("change", e);
475475

476-
var source = this.session.getValue();
477-
var _self = this;
478-
479-
setTimeout(function() {
480-
var cursor = _self.getCursorPosition();
481-
var line = _self.session.getLine(cursor.row);
482-
483-
_self.autocomplete.activate(cursor.row, cursor.column);
484-
_self.autocomplete.suggest(name);
485-
}, 0);
486-
487476
// update cursor because tab characters can influence the cursor position
488477
this.$cursorChange();
489478
};
490479

491-
this.$hideautocomplete = function() {
492-
if (this.autocomplete.isActive())
493-
this.autocomplete.deactivate();
494-
};
495-
496480
this.onTokenizerUpdate = function(e) {
497481
var rows = e.data;
498482
this.renderer.updateLines(rows.first, rows.last);

0 commit comments

Comments
 (0)