Temporary files are not deleted if TemporaryFile objects are not garbage collected #5545

Activity

1. richdougherty commented on Feb 2, 2016

   

   richdougherty

   on Feb 2, 2016

   Member

   More actions

   I agree this is a problem, see my comment from here:

   …I don't really like the way the delete happens in a finalize method. I'd like us to have a better way of cleaning up resources when a request finishes. Maybe each request could have an object where we could add "request finished" hooks.
2. wsargent commented on Feb 2, 2016

   

   wsargent

   on Feb 2, 2016

   Member

   More actions

   Possibly a dup of #5459
3. mkurz commented on Mar 6, 2016

   

   mkurz

   on Mar 6, 2016

   Last edited by mkurz

   Member

   More actions

   Related: #4707, #3913, #6786 and #4762
   Also this comment:

   I'd rather the user explicitly does something if they want to keep it around after the request is complete, e.g. some sort of acquire/release operation, or maybe moving the file elsewhere.

   As discussed in one of the above issues I am assigning the Play 3 milestone.
4. mkurz

   added this to the 3.0.0 milestone on Mar 6, 2016
5. mkurz

   modified the milestones: 2.5.13, 3.0.0 on Feb 15, 2017
6. gmethvin

   modified the milestones: 2.7.0This milestone has been deleted, 3.0.0 on Jun 22, 2017
7. wsargent commented on Jun 23, 2017

   

   wsargent

   on Jun 23, 2017

   Member

   More actions

   This can be handled by enabling the TemporaryFileReaper in 2.6.x: https://www.playframework.com/documentation/2.6.x/ScalaFileUpload#Cleaning-up-temporary-files
8. wsargent

   closed this as completedon Jun 23, 2017
9. mkurz

   modified the milestones: 2.6.0, 2.7.0This milestone has been deleted on Jun 26, 2017