Skip to content

Commit 409afdb

Browse files
vihangmvihangm
committed
Clamp down bazel visibility
Summary: Move from `visibility:public` to `src:__subpackages__` Further restrict `src/stirling`, `src/cloud` and `src/vizier` to their own directories where possible. Test Plan: Build and test all. Reviewers: michelle, zasgar, oazizi Reviewed By: zasgar JIRA Issues: PP-2567 Differential Revision: https://phab.corp.pixielabs.ai/D8031 GitOrigin-RevId: a9547b6
1 parent e9d1de9 commit 409afdb

File tree

328 files changed

+544
-461
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

328 files changed

+544
-461
lines changed

‎src/api/BUILD.bazel‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ load("@rules_python//python:defs.bzl", "py_binary")
33
filegroup(
44
name = "py_examples",
55
srcs = glob(["python_examples/*.py"]),
6-
visibility = ["//visibility:public"],
6+
visibility = ["//src:__subpackages__"],
77
)
88

99
py_binary(

‎src/api/go/pxapi/BUILD.bazel‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ go_library(
1111
"vizier.go",
1212
],
1313
importpath = "pixielabs.ai/pixielabs/src/api/go/pxapi",
14-
visibility = ["//visibility:public"],
14+
visibility = ["//src:__subpackages__"],
1515
deps = [
1616
"//src/api/go/pxapi/errdefs",
1717
"//src/api/go/pxapi/types",
@@ -35,7 +35,7 @@ filegroup(
3535
"//src/api/go/pxapi/errdefs:errors_group",
3636
"//src/api/go/pxapi/types:types_group",
3737
],
38-
visibility = ["//visibility:public"],
38+
visibility = ["//src:__subpackages__"],
3939
)
4040

4141
go_test(

‎src/api/go/pxapi/errdefs/BUILD.bazel‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ go_library(
99
"parsers.go",
1010
],
1111
importpath = "pixielabs.ai/pixielabs/src/api/go/pxapi/errdefs",
12-
visibility = ["//visibility:public"],
12+
visibility = ["//src:__subpackages__"],
1313
deps = [
1414
"//src/api/public/vizierapipb:public_vizier_pl_go_proto",
1515
"@org_golang_google_grpc//codes",
@@ -29,5 +29,5 @@ filegroup(
2929
"*.go",
3030
],
3131
),
32-
visibility = ["//visibility:public"],
32+
visibility = ["//src:__subpackages__"],
3333
)

‎src/api/go/pxapi/errdefs/formatters/BUILD.bazel‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ go_library(
88
"table.go",
99
],
1010
importpath = "pixielabs.ai/pixielabs/src/api/go/pxapi/errdefs/formatters",
11-
visibility = ["//visibility:public"],
11+
visibility = ["//src:__subpackages__"],
1212
deps = [
1313
"//src/api/go/pxapi/errdefs",
1414
"//src/api/go/pxapi/types",

‎src/api/go/pxapi/muxes/BUILD.bazel‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ go_library(
77
"regex.go",
88
],
99
importpath = "pixielabs.ai/pixielabs/src/api/go/pxapi/muxes",
10-
visibility = ["//visibility:public"],
10+
visibility = ["//src:__subpackages__"],
1111
deps = [
1212
"//src/api/go/pxapi",
1313
"//src/api/go/pxapi/types",

‎src/api/go/pxapi/types/BUILD.bazel‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ go_library(
88
"types.go",
99
],
1010
importpath = "pixielabs.ai/pixielabs/src/api/go/pxapi/types",
11-
visibility = ["//visibility:public"],
11+
visibility = ["//src:__subpackages__"],
1212
deps = [
1313
"//src/api/public/vizierapipb:public_vizier_pl_go_proto",
1414
"@com_github_gofrs_uuid//:uuid",
@@ -22,5 +22,5 @@ filegroup(
2222
"*.go",
2323
],
2424
),
25-
visibility = ["//visibility:public"],
25+
visibility = ["//src:__subpackages__"],
2626
)

‎src/api/go_examples/basic_example/BUILD.bazel‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ go_library(
1515
go_binary(
1616
name = "basic_example",
1717
embed = [":basic_example_lib"],
18-
visibility = ["//visibility:public"],
18+
visibility = ["//src:__subpackages__"],
1919
)
2020

2121
filegroup(
2222
name = "basic_example_group",
2323
srcs = glob(["*.go"]),
24-
visibility = ["//visibility:public"],
24+
visibility = ["//src:__subpackages__"],
2525
)

‎src/api/go_examples/example_mux/BUILD.bazel‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@ go_library(
1717
go_binary(
1818
name = "example_mux",
1919
embed = [":example_mux_lib"],
20-
visibility = ["//visibility:public"],
20+
visibility = ["//src:__subpackages__"],
2121
)

‎src/api/public/cloudapipb/BUILD.bazel‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# gazelle:ignore
22

3-
package(default_visibility = ["//visibility:public"])
3+
package(default_visibility = ["//src:__subpackages__"])
44

55
load("//bazel:proto_compile.bzl", "pl_cc_proto_library", "pl_go_proto_library", "pl_proto_library", "pl_py_grpc_library")
66

77
pl_proto_library(
88
name = "cloudapi_pl_proto",
99
srcs = ["cloudapi.proto"],
10-
visibility = ["//visibility:public"],
10+
visibility = ["//src:__subpackages__"],
1111
deps = [
1212
"//src/api/public/uuidpb:uuid_pl_proto",
1313
"@gogo_special_proto//github.com/gogo/protobuf/gogoproto",
@@ -18,7 +18,7 @@ pl_go_proto_library(
1818
name = "public_cloudapi_pl_go_proto",
1919
importpath = "pixielabs.ai/pixielabs/src/api/public/cloudapipb",
2020
proto = ":cloudapi_pl_proto",
21-
visibility = ["//visibility:public"],
21+
visibility = ["//src:__subpackages__"],
2222
deps = [
2323
"//src/api/public/uuidpb:uuid_pl_go_proto",
2424
"@com_github_gogo_protobuf//gogoproto:go_default_library",
@@ -29,7 +29,7 @@ pl_py_grpc_library(
2929
name = "cloudapi_pl_py_grpc",
3030
imports = ["../../../../"],
3131
proto = ":cloudapi_pl_proto",
32-
visibility = ["//visibility:public"],
32+
visibility = ["//src:__subpackages__"],
3333
deps = [
3434
"//src/api/public/uuidpb:uuid_pl_py_proto",
3535
],
@@ -41,5 +41,5 @@ filegroup(
4141
"*.pb.go",
4242
"*.proto",
4343
]),
44-
visibility = ["//visibility:public"],
44+
visibility = ["//src:__subpackages__"],
4545
)

‎src/api/public/uuidpb/BUILD.bazel‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,28 +5,28 @@ load("//bazel:proto_compile.bzl", "pl_cc_proto_library", "pl_go_proto_library",
55
pl_proto_library(
66
name = "uuid_pl_proto",
77
srcs = ["uuid.proto"],
8-
visibility = ["//visibility:public"],
8+
visibility = ["//src:__subpackages__"],
99
deps = [],
1010
)
1111

1212
pl_cc_proto_library(
1313
name = "uuid_pl_cc_proto",
1414
proto = ":uuid_pl_proto",
15-
visibility = ["//visibility:public"],
15+
visibility = ["//src:__subpackages__"],
1616
)
1717

1818
pl_go_proto_library(
1919
name = "uuid_pl_go_proto",
2020
importpath = "pixielabs.ai/pixielabs/src/api/public/uuidpb",
2121
proto = ":uuid_pl_proto",
22-
visibility = ["//visibility:public"],
22+
visibility = ["//src:__subpackages__"],
2323
)
2424

2525
pl_py_proto_library(
2626
name = "uuid_pl_py_proto",
2727
imports = ["../../../"],
2828
proto = ":uuid_pl_proto",
29-
visibility = ["//visibility:public"],
29+
visibility = ["//src:__subpackages__"],
3030
)
3131

3232
filegroup(
@@ -35,5 +35,5 @@ filegroup(
3535
"*.pb.go",
3636
"*.proto",
3737
]),
38-
visibility = ["//visibility:public"],
38+
visibility = ["//src:__subpackages__"],
3939
)

0 commit comments

Comments
 (0)