px cli: Stop showing spinners in quiet mode.

Pete Stevenson · copybaranaut · commit 2a5d80afd0cf · 2022-07-18T23:33:50.000Z
Summary: Previously, even with `-q|-quiet`, the px cli would show spinners which can cause log spam. In this diff, we remove the spinners if quiet mode is enabled. Test Plan: Tested locally, in continuous use by the stirling perf eval project. Reviewers: #stirling, michelle, vihang, zasgar Reviewed By: vihang Subscribers: yzhao Signed-off-by: Pete Stevenson <jps@pixielabs.ai> Differential Revision: https://phab.corp.pixielabs.ai/D11834 GitOrigin-RevId: 5f5b69f
diff --git a/src/pixie_cli/pkg/components/spinner.go b/src/pixie_cli/pkg/components/spinner.go
@@ -22,6 +22,7 @@ import (
 	"fmt"
 
 	"github.com/fatih/color"
+	"github.com/spf13/viper"
 	"github.com/vbauerster/mpb/v4"
 	"github.com/vbauerster/mpb/v4/decor"
 )
@@ -50,8 +51,13 @@ type SpinnerTable struct {
 
 // NewSpinnerTable creates a new table with Spinners.
 func NewSpinnerTable() *SpinnerTable {
+	var opt mpb.ContainerOption
+	if viper.GetBool("quiet") {
+		opt = mpb.WithOutput(nil)
+	}
+
 	return &SpinnerTable{
-		mpb.New(),
+		mpb.New(opt),
 		make([]*TaskInfo, 0),
 	}
 }
