* raise a somewhat more helpfull exception when github.com returns an error

Maximillian Dornseif · Maximillian Dornseif · commit 3dd8d9e85493 · 2010-01-01T10:36:04.000+01:00
* added docstrings on some functions which made me stumble
diff --git a/github2/repositories.py b/github2/repositories.py
@@ -28,9 +28,14 @@ def show(self, project):
                               datatype=Repository)
 
     def list(self, for_user=None):
+        """Return a list of all repositories for a user.
+
+        If no user is given, repositoris for the currently logged in user are
+        returned.
+        """
         for_user = for_user or self.request.username
         return self.get_values("show", for_user, filter="repositories",
-                datatype=Repository)
+                               datatype=Repository)
 
     def watch(self, project):
         return self.make_request("watch", project)
@@ -58,13 +63,22 @@ def set_public(self, repo_name):
         return self.make_request("set/public", repo_name)
 
     def list_collaborators(self, project):
+        """Lists all the collaborators in a project (user/repro)."""
         return self.make_request("show", project, "collaborators",
                                  filter="collaborators")
 
     def add_collaborator(self, repo_name, username):
+        """Adds an add_collaborator to a repro.
+
+        Do not prefix repro_name with the user owning the repro like you
+        do in list_collaborators()"""
         return self.make_request("collaborators", repo_name, "add", username)
 
     def remove_collaborator(self, repo_name, username):
+        """Removes an add_collaborator from a repro.
+
+        Do not prefix repro_name with the user owning the repro like you
+        do in list_collaborators()"""
         return self.make_request("collaborators", repo_name, "remove",
                                  username, method="POST")
 
diff --git a/github2/request.py b/github2/request.py
@@ -78,6 +78,9 @@ def raw_request(self, url, extra_post_data, method="GET"):
         if self.debug:
             sys.stderr.write("URL:[%s] POST_DATA:%s RESPONSE_TEXT: [%s]\n" % (
                                 path, post_data, response_text))
+        if response.status >= 400:
+            raise RuntimeError("unexpected response from github.com %d: %r" % (
+                               response.status, response_text))
         json = simplejson.loads(response_text)
         if json.get("error"):
             raise self.GithubError(json["error"][0]["error"])
