Fix error when removing all USB Device Filters

studnitskiy · studnitskiy · commit 9b65e1b45717 · 2025-10-31T19:47:16.000-07:00
After adding USB Device Filters and saving, it was not possible to
remove the last filter, an exception occurred on save.
The root cause was that USBDeviceFilters is empty when there are
no more filters, and count fails. The issue is now fixed.
diff --git a/endpoints/lib/vboxconnector.php b/endpoints/lib/vboxconnector.php
@@ -2347,7 +2347,7 @@ public function remote_machineSave($args) {
 						}
 
 						// Exists in new?
-						if(count($args['USBDeviceFilters'][$i])) {
+						if($args['USBDeviceFilters'] && count($args['USBDeviceFilters'][$i])) {
 
 							// Create filter
 							$f = $m->USBDeviceFilters->createDeviceFilter($args['USBDeviceFilters'][$i]['name']);

Original file line number	Diff line number	Diff line change
`@@ -2347,7 +2347,7 @@ public function remote_machineSave($args) {`
`2347`	`2347`	`}`
`2348`	`2348`
`2349`	`2349`	`// Exists in new?`
`2350`		`- if(count($args['USBDeviceFilters'][$i])) {`
	`2350`	`+ if($args['USBDeviceFilters'] && count($args['USBDeviceFilters'][$i])) {`
`2351`	`2351`
`2352`	`2352`	`// Create filter`
`2353`	`2353`	`$f = $m->USBDeviceFilters->createDeviceFilter($args['USBDeviceFilters'][$i]['name']);`