Fix missing NVRAM file when manually checking Enable EFI in System settings

studnitskiy · studnitskiy · commit 41d14053c230 · 2025-10-18T18:13:04.000-07:00
NVRAM file is not created for new VMs where EFI is not set by defalut (I guess pretty much anything except Windows 11 and macOS). When manually checking "Enable EFI" in System settings later, the file was not created, and the VM settings became unavailable. I was trying to make the secure boot flag working, but due to the issue with vboxwebsrv always reporting it as enabled, and inability to tell whether it's disabled, I had to turn this off, and carelessly also commented the code creating the NVRAM file. This part is now restored. Fixes #369
diff --git a/endpoints/lib/vboxconnector.php b/endpoints/lib/vboxconnector.php
@@ -1875,8 +1875,8 @@ public function remote_machineSave($args) {
 			$m->Platform->X86->setCPUProperty('LongMode', ($guestOS->is64Bit ? 1 : 0));
 		}
 
-		/* secureBootEnabled reported incorrectly by vboxwebsrv
 		$oldFirmware = (string)$m->FirmwareSettings->firmwareType;
+		/* secureBootEnabled reported incorrectly by vboxwebsrv
 		$oldSecureBoot = ($oldFirmware != 'BIOS' && $m->nonVolatileStore->uefiVariableStore != null ? $m->nonVolatileStore->uefiVariableStore->secureBootEnabled : false);
 		*/
 	
@@ -1891,12 +1891,12 @@ public function remote_machineSave($args) {
 		$m->Platform->X86->setCPUProperty('LongMode', (strpos($args['OSTypeId'],'_64') > - 1 ? 1 : 0));
 		$m->trustedPlatformModule->type = $args['trustedPlatformModule']['type'];
 
-		/* secureBootEnabled reported incorrectly by vboxwebsrv
 		if($oldFirmware == 'BIOS' && $args['firmwareType'] == 'EFI') {
 			$m->nonVolatileStore->initUefiVariableStore(0);
 			$m->nonVolatileStore->uefiVariableStore->enrollOraclePlatformKey();
 			$m->nonVolatileStore->uefiVariableStore->enrollDefaultMsSignatures();
 		}
+		/* secureBootEnabled reported incorrectly by vboxwebsrv
 		if($args['firmwareType'] != 'BIOS' && $oldSecureBoot != (bool)$args['secureBootEnabled']) {
 			$m->nonVolatileStore->uefiVariableStore->secureBootEnabled = (bool)$args['secureBootEnabled'];
 		}
