Merge pull request microsoft#5875 from weswigham/no-in-rule

weswigham · weswigham · commit e134169590ed · 2015-12-01T15:36:51.000-08:00
lint rule forbidding the in keyword binary expression
diff --git a/Jakefile.js b/Jakefile.js
@@ -113,7 +113,8 @@ var scriptSources = [
     "tslint/nextLineRule.ts",
     "tslint/noNullRule.ts",
     "tslint/preferConstRule.ts",
-    "tslint/typeOperatorSpacingRule.ts"
+    "tslint/typeOperatorSpacingRule.ts",
+    "tslint/noInOperatorRule.ts"
 ].map(function (f) {
     return path.join(scriptsDirectory, f);
 });
@@ -875,7 +876,8 @@ var tslintRules = ([
     "noNullRule",
     "preferConstRule",
     "booleanTriviaRule",
-    "typeOperatorSpacingRule"
+    "typeOperatorSpacingRule",
+    "noInOperatorRule"
 ]);
 var tslintRulesFiles = tslintRules.map(function(p) {
     return path.join(tslintRuleDir, p + ".ts");
diff --git a/scripts/tslint/noInOperatorRule.ts b/scripts/tslint/noInOperatorRule.ts
@@ -0,0 +1,20 @@
+import * as Lint from "tslint/lib/lint";
+import * as ts from "typescript";
+
+
+export class Rule extends Lint.Rules.AbstractRule {
+    public static FAILURE_STRING = "Don't use the 'in' keyword - use 'hasProperty' to check for key presence instead";
+
+    public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
+        return this.applyWithWalker(new InWalker(sourceFile, this.getOptions()));
+    }
+}
+
+class InWalker extends Lint.RuleWalker {
+    visitNode(node: ts.Node) {
+        super.visitNode(node);
+        if (node.kind === ts.SyntaxKind.InKeyword && node.parent && node.parent.kind === ts.SyntaxKind.BinaryExpression) {
+            this.addFailure(this.createFailure(node.getStart(), node.getWidth(), Rule.FAILURE_STRING));
+        }
+    }
+}
diff --git a/tslint.json b/tslint.json
@@ -40,6 +40,7 @@
         "no-null": true,
         "boolean-trivia": true,
         "type-operator-spacing": true,
-        "prefer-const": true
+        "prefer-const": true,
+        "no-in-operator": true
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@`
`40`	`40`	`"no-null": true,`
`41`	`41`	`"boolean-trivia": true,`
`42`	`42`	`"type-operator-spacing": true,`
`43`		`- "prefer-const": true`
	`43`	`+ "prefer-const": true,`
	`44`	`+ "no-in-operator": true`
`44`	`45`	`}`
`45`	`46`	`}`