Don't return the last falsy value when forEach'ing over an array.

CyrusNajmabadi · CyrusNajmabadi · commit bce8314e0b38 · 2014-12-04T13:11:42.000-08:00
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -28,15 +28,15 @@ module ts {
     export interface StringSet extends Map<any> { }
 
     export function forEach<T, U>(array: T[], callback: (element: T) => U): U {
-        var result: U;
         if (array) {
             for (var i = 0, len = array.length; i < len; i++) {
-                if (result = callback(array[i])) {
-                    break;
+                var result = callback(array[i]);
+                if (result) {
+                    return result;
                 }
             }
         }
-        return result;
+        return undefined;
     }
 
     export function contains<T>(array: T[], value: T): boolean {

Original file line number	Diff line number	Diff line change
`@@ -28,15 +28,15 @@ module ts {`
`28`	`28`	`export interface StringSet extends Map<any> { }`
`29`	`29`
`30`	`30`	`export function forEach<T, U>(array: T[], callback: (element: T) => U): U {`
`31`		`- var result: U;`
`32`	`31`	`if (array) {`
`33`	`32`	`for (var i = 0, len = array.length; i < len; i++) {`
`34`		`- if (result = callback(array[i])) {`
`35`		`- break;`
	`33`	`+ var result = callback(array[i]);`
	`34`	`+ if (result) {`
	`35`	`+ return result;`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`	`}`
`39`		`- return result;`
	`39`	`+ return undefined;`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`export function contains<T>(array: T[], value: T): boolean {`