Only mark symbols found in a local symbol table

mhegazy · mhegazy · commit b40512d8a21f · 2016-06-30T01:00:53.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -51,7 +51,7 @@ namespace ts {
         const compilerOptions = host.getCompilerOptions();
         const languageVersion = compilerOptions.target || ScriptTarget.ES3;
         const modulekind = getEmitModuleKind(compilerOptions);
-        const noUnusedIdentifiers = compilerOptions.noUnusedLocals || compilerOptions.noUnusedParameters;
+        const noUnusedIdentifiers = !!compilerOptions.noUnusedLocals || !!compilerOptions.noUnusedParameters;
         const allowSyntheticDefaultImports = typeof compilerOptions.allowSyntheticDefaultImports !== "undefined" ? compilerOptions.allowSyntheticDefaultImports : modulekind === ModuleKind.System;
         const strictNullChecks = compilerOptions.strictNullChecks;
 
@@ -849,6 +849,10 @@ namespace ts {
                 location = location.parent;
             }
 
+            if (result && nameNotFoundMessage && noUnusedIdentifiers) {
+                result.isReferenced = true;
+            }
+
             if (!result) {
                 result = getSymbol(globals, name, meaning);
             }
@@ -899,10 +903,6 @@ namespace ts {
                         error(errorLocation, Diagnostics.Identifier_0_must_be_imported_from_a_module, name);
                     }
                 }
-
-                if (result && noUnusedIdentifiers && !isInAmbientContext(location)) {
-                    result.isReferenced = true;
-                }
             }
             return result;
         }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ namespace ts {`
`51`	`51`	`const compilerOptions = host.getCompilerOptions();`
`52`	`52`	`const languageVersion = compilerOptions.target \|\| ScriptTarget.ES3;`
`53`	`53`	`const modulekind = getEmitModuleKind(compilerOptions);`
`54`		`- const noUnusedIdentifiers = compilerOptions.noUnusedLocals \|\| compilerOptions.noUnusedParameters;`
	`54`	`+ const noUnusedIdentifiers = !!compilerOptions.noUnusedLocals \|\| !!compilerOptions.noUnusedParameters;`
`55`	`55`	`const allowSyntheticDefaultImports = typeof compilerOptions.allowSyntheticDefaultImports !== "undefined" ? compilerOptions.allowSyntheticDefaultImports : modulekind === ModuleKind.System;`
`56`	`56`	`const strictNullChecks = compilerOptions.strictNullChecks;`
`57`	`57`
`@@ -849,6 +849,10 @@ namespace ts {`
`849`	`849`	`location = location.parent;`
`850`	`850`	`}`
`851`	`851`
	`852`	`+ if (result && nameNotFoundMessage && noUnusedIdentifiers) {`
	`853`	`+ result.isReferenced = true;`
	`854`	`+ }`
	`855`	`+`
`852`	`856`	`if (!result) {`
`853`	`857`	`result = getSymbol(globals, name, meaning);`
`854`	`858`	`}`
`@@ -899,10 +903,6 @@ namespace ts {`
`899`	`903`	`error(errorLocation, Diagnostics.Identifier_0_must_be_imported_from_a_module, name);`
`900`	`904`	`}`
`901`	`905`	`}`
`902`		`-`
`903`		`- if (result && noUnusedIdentifiers && !isInAmbientContext(location)) {`
`904`		`- result.isReferenced = true;`
`905`		`- }`
`906`	`906`	`}`
`907`	`907`	`return result;`
`908`	`908`	`}`