Drop Protocol version

kamil-tekiela · MauricioFauth · commit fd7e1dc4efba · 2024-11-25T20:37:38.000-03:00
Signed-off-by: Kamil Tekiela &lt;tekiela246@gmail.com&gt;
diff --git a/resources/templates/home/index.twig b/resources/templates/home/index.twig
@@ -194,10 +194,6 @@
                 {{ t('Server version:') }}
                 {{ database_server.version }}
               </li>
-              <li class="list-group-item">
-                {{ t('Protocol version:') }}
-                {{ database_server.protocol }}
-              </li>
               <li class="list-group-item">
                 {{ t('User:') }}
                 {{ database_server.user }}
diff --git a/src/Controllers/HomeController.php b/src/Controllers/HomeController.php
@@ -167,7 +167,6 @@ public function __invoke(ServerRequest $request): Response
                 'type' => Util::getServerType(),
                 'connection' => Generator::getServerSSL(),
                 'version' => $this->dbi->getVersionString() . ' - ' . $this->dbi->getVersionComment(),
-                'protocol' => $this->dbi->getProtoInfo(),
                 'user' => $this->dbi->fetchValue('SELECT USER();'),
                 'charset' => $serverCharset->getDescription() . ' (' . $serverCharset->getName() . ')',
             ];
diff --git a/src/DatabaseInterface.php b/src/DatabaseInterface.php
@@ -1733,20 +1733,6 @@ public function getHostInfo(ConnectionType $connectionType = ConnectionType::Use
         return $this->extension->getHostInfo($this->connections[$connectionType->value]);
     }
 
-    /**
-     * Returns the version of the MySQL protocol used
-     *
-     * @return int|bool version of the MySQL protocol used
-     */
-    public function getProtoInfo(ConnectionType $connectionType = ConnectionType::User): int|bool
-    {
-        if (! isset($this->connections[$connectionType->value])) {
-            return false;
-        }
-
-        return $this->extension->getProtoInfo($this->connections[$connectionType->value]);
-    }
-
     /**
      * returns a string that represents the client library version
      *
diff --git a/src/Dbal/DbalInterface.php b/src/Dbal/DbalInterface.php
@@ -452,13 +452,6 @@ public function nextResult(ConnectionType $connectionType = ConnectionType::User
      */
     public function getHostInfo(ConnectionType $connectionType = ConnectionType::User): string|bool;
 
-    /**
-     * Returns the version of the MySQL protocol used
-     *
-     * @return int|bool version of the MySQL protocol used
-     */
-    public function getProtoInfo(ConnectionType $connectionType = ConnectionType::User): int|bool;
-
     /**
      * returns a string that represents the client library version
      *
diff --git a/src/Dbal/DbiExtension.php b/src/Dbal/DbiExtension.php
@@ -65,13 +65,6 @@ public function storeResult(Connection $connection): ResultInterface|false;
      */
     public function getHostInfo(Connection $connection): string;
 
-    /**
-     * Returns the version of the MySQL protocol used
-     *
-     * @return int version of the MySQL protocol used
-     */
-    public function getProtoInfo(Connection $connection): int;
-
     /**
      * returns a string that represents the client library version
      *
diff --git a/src/Dbal/DbiMysqli.php b/src/Dbal/DbiMysqli.php
@@ -229,20 +229,6 @@ public function getHostInfo(Connection $connection): string
         return $mysqli->host_info;
     }
 
-    /**
-     * Returns the version of the MySQL protocol used
-     *
-     * @return int version of the MySQL protocol used
-     */
-    public function getProtoInfo(Connection $connection): int
-    {
-        /** @var mysqli $mysqli */
-        $mysqli = $connection->connection;
-
-        // phpcs:ignore Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
-        return $mysqli->protocol_version;
-    }
-
     /**
      * returns a string that represents the client library version
      *
diff --git a/tests/unit/Stubs/DbiDummy.php b/tests/unit/Stubs/DbiDummy.php
@@ -236,16 +236,6 @@ public function getHostInfo(Connection $connection): string
         return '';
     }
 
-    /**
-     * Returns the version of the MySQL protocol used
-     *
-     * @return int version of the MySQL protocol used
-     */
-    public function getProtoInfo(Connection $connection): int
-    {
-        return -1;
-    }
-
     /**
      * returns a string that represents the client library version
      *
