Merge pull request #18826 from kamil-tekiela/cyclomatic-complexity

MauricioFauth · web-flow · commit f71c29c402ea · 2023-12-04T22:01:20.000-03:00
Introduce private method getProfilingChart in Sql
diff --git a/src/Sql.php b/src/Sql.php
@@ -1005,13 +1005,7 @@ private function getQueryResponseForNoResultsReturned(
             true,
         );
 
-        $profilingChart = '';
-        if ($profilingResults !== []) {
-            $profiling = $this->getDetailedProfilingStats($profilingResults);
-            if ($profiling !== []) {
-                $profilingChart = $this->template->render('sql/profiling_chart', ['profiling' => $profiling]);
-            }
-        }
+        $profilingChart = $this->getProfilingChart($profilingResults);
 
         $bookmark = '';
         $bookmarkFeature = $this->relation->getRelationParameters()->bookmarkFeature;
@@ -1112,14 +1106,12 @@ private function getHtmlForSqlQueryResultsTable(
         if ($statementInfo->isProcedure) {
             return $this->getHtmlForStoredProcedureResults(
                 $result,
-                $numRows,
                 $displayResultsObject,
                 $statementInfo,
                 $showTable,
                 $printView,
                 $editable,
                 $isBrowseDistinct,
-                $displayParts,
                 $isLimitedDisplay,
             );
         }
@@ -1147,20 +1139,15 @@ private function getHtmlForSqlQueryResultsTable(
         return $displayResultsObject->getTable($result, $displayParts, $statementInfo, $isLimitedDisplay);
     }
 
-    /**
-     * @param mixed[]|null $showTable table definitions
-     * @psalm-param int|numeric-string $numRows
-     */
+    /** @param mixed[]|null $showTable table definitions */
     private function getHtmlForStoredProcedureResults(
         ResultInterface $result,
-        int|string $numRows,
         DisplayResults $displayResultsObject,
         StatementInfo $statementInfo,
         array|null $showTable,
         bool $printView,
         bool $editable,
         bool $isBrowseDistinct,
-        DisplayParts $displayParts,
         bool $isLimitedDisplay,
     ): string {
         $tableHtml = '';
@@ -1428,13 +1415,7 @@ private function getQueryResponseForResultsReturned(
             $dispMessage ?? '',
         );
 
-        $profilingChartHtml = '';
-        if ($profilingResults !== []) {
-            $profiling = $this->getDetailedProfilingStats($profilingResults);
-            if ($profiling !== []) {
-                $profilingChartHtml = $this->template->render('sql/profiling_chart', ['profiling' => $profiling]);
-            }
-        }
+        $profilingChartHtml = $this->getProfilingChart($profilingResults);
 
         $missingUniqueColumnMessage = $this->getMessageIfMissingColumnIndex($table, $db, $editable, $hasUnique);
 
@@ -1733,4 +1714,19 @@ private function getIndexList(string $table, string $db): string
             'indexes_duplicates' => $indexesDuplicates,
         ]);
     }
+
+    /** @psalm-param list<array{Status: non-empty-string, Duration: numeric-string}> $profilingResults */
+    private function getProfilingChart(array $profilingResults): string
+    {
+        if ($profilingResults === []) {
+            return '';
+        }
+
+        $profiling = $this->getDetailedProfilingStats($profilingResults);
+        if ($profiling === []) {
+            return '';
+        }
+
+        return $this->template->render('sql/profiling_chart', ['profiling' => $profiling]);
+    }
 }
