Add new variable for version up to date message

MauricioFauth · MauricioFauth · commit edc4a0d41f34 · 2023-04-05T15:45:47.000-03:00
Fixes error TS2740 reported by TypeScript.

Signed-off-by: Maurício Meneghini Fauth &lt;mauricio@fauth.dev&gt;
diff --git a/js/src/modules/git-info.ts b/js/src/modules/git-info.ts
@@ -88,8 +88,9 @@ const GitInfo = {
                 $('#maincontainer').append($(mainContainerDiv));
             }
 
+            let upToDateMessage: Text | null = null;
             if (latest === current) {
-                versionInformationMessage = document.createTextNode(' (' + window.Messages.strUpToDate + ')');
+                upToDateMessage = document.createTextNode(' (' + window.Messages.strUpToDate + ')');
             }
 
             /* Remove extra whitespace */
@@ -100,7 +101,11 @@ const GitInfo = {
 
             const $liPmaVersion = $('#li_pma_version');
             $liPmaVersion.find('span.latest').remove();
-            $liPmaVersion.append($(versionInformationMessage));
+            if (upToDateMessage !== null) {
+                $liPmaVersion.append($(upToDateMessage));
+            } else {
+                $liPmaVersion.append($(versionInformationMessage));
+            }
         }
     },
 
diff --git a/webpack.config.cjs b/webpack.config.cjs
@@ -21,7 +21,6 @@ const typeScriptErrorsToIgnore = [
     2469, // TS2469: The '+' operator cannot be applied to type 'symbol'.
     2538, // TS2538: Type '%s' cannot be used as an index type.
     2551, // TS2551: Property '%s' does not exist on type '%s'. Did you mean '%s'?
-    2740, // TS2740: Type 'Text' is missing the following properties from type 'HTMLSpanElement': accessKey, accessKeyLabel, autocapitalize, dir, and 226 more.
     2769, // TS2769: No overload matches this call.
     5096, // TS5096: Option 'allowImportingTsExtensions' can only be used when either 'noEmit' or 'emitDeclarationOnly' is set.
 ];

Original file line number	Diff line number	Diff line change
`@@ -88,8 +88,9 @@ const GitInfo = {`
`88`	`88`	`$('#maincontainer').append($(mainContainerDiv));`
`89`	`89`	`}`
`90`	`90`
	`91`	`+ let upToDateMessage: Text \| null = null;`
`91`	`92`	`if (latest === current) {`
`92`		`- versionInformationMessage = document.createTextNode(' (' + window.Messages.strUpToDate + ')');`
	`93`	`+ upToDateMessage = document.createTextNode(' (' + window.Messages.strUpToDate + ')');`
`93`	`94`	`}`
`94`	`95`
`95`	`96`	`/* Remove extra whitespace */`
`@@ -100,7 +101,11 @@ const GitInfo = {`
`100`	`101`
`101`	`102`	`const $liPmaVersion = $('#li_pma_version');`
`102`	`103`	`$liPmaVersion.find('span.latest').remove();`
`103`		`- $liPmaVersion.append($(versionInformationMessage));`
	`104`	`+ if (upToDateMessage !== null) {`
	`105`	`+ $liPmaVersion.append($(upToDateMessage));`
	`106`	`+ } else {`
	`107`	`+ $liPmaVersion.append($(versionInformationMessage));`
	`108`	`+ }`
`104`	`109`	`}`
`105`	`110`	`},`
`106`	`111`