Refactor the NodeColumn::getTruncateValue method

MauricioFauth · MauricioFauth · commit e641c7011001 · 2022-10-16T17:29:09.000-03:00
Removes the unnecessary switch construct.

Signed-off-by: Maurício Meneghini Fauth &lt;mauricio@fauth.dev&gt;
diff --git a/libraries/classes/Navigation/Nodes/NodeColumn.php b/libraries/classes/Navigation/Nodes/NodeColumn.php
@@ -100,19 +100,12 @@ private function getDisplayName($item)
      *
      * @return string truncated value
      */
-    public function getTruncateValue($key, $value)
+    private function getTruncateValue($key, $value)
     {
-        $retval = '';
-
-        switch ($key) {
-            case 'default':
-                strlen($value) > 6 ? $retval .= substr($value, 0, 6) . '...' : $retval = $value;
-                break;
-            default:
-                $retval = $value;
-                break;
+        if ($key === 'default' && strlen($value) > 6) {
+            return substr($value, 0, 6) . '...';
         }
 
-        return $retval;
+        return $value;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -100,19 +100,12 @@ private function getDisplayName($item)`
`100`	`100`	`*`
`101`	`101`	`* @return string truncated value`
`102`	`102`	`*/`
`103`		`- public function getTruncateValue($key, $value)`
	`103`	`+ private function getTruncateValue($key, $value)`
`104`	`104`	`{`
`105`		`- $retval = '';`
`106`		`-`
`107`		`- switch ($key) {`
`108`		`- case 'default':`
`109`		`- strlen($value) > 6 ? $retval .= substr($value, 0, 6) . '...' : $retval = $value;`
`110`		`- break;`
`111`		`- default:`
`112`		`- $retval = $value;`
`113`		`- break;`
	`105`	`+ if ($key === 'default' && strlen($value) > 6) {`
	`106`	`+ return substr($value, 0, 6) . '...';`
`114`	`107`	`}`
`115`	`108`
`116`		`- return $retval;`
	`109`	`+ return $value;`
`117`	`110`	`}`
`118`	`111`	`}`