Add method to validate logtype request param

MauricioFauth · MauricioFauth · commit db75ac370d66 · 2022-11-05T16:46:48.000-03:00
Signed-off-by: Maurício Meneghini Fauth &lt;mauricio@fauth.dev&gt;
diff --git a/libraries/classes/Controllers/Table/TrackingController.php b/libraries/classes/Controllers/Table/TrackingController.php
@@ -20,6 +20,7 @@
 use function define;
 use function explode;
 use function htmlspecialchars;
+use function in_array;
 use function is_array;
 use function sprintf;
 use function strtotime;
@@ -110,10 +111,8 @@ public function __invoke(ServerRequest $request): void
                 $versionParam
             );
 
-            $logType = $request->getParsedBodyParam('logtype', 'schema_and_data');
-            if (! isset($_POST['logtype'])) {
-                $_POST['logtype'] = 'schema_and_data';
-            }
+            $logType = $this->validateLogTypeParam($request->getParsedBodyParam('logtype'));
+            $_POST['logtype'] = $logType;
 
             if ($logType === 'schema') {
                 $GLOBALS['selection_schema'] = true;
@@ -293,4 +292,14 @@ public function __invoke(ServerRequest $request): void
             'main' => $main,
         ]);
     }
+
+    /**
+     * @param mixed $param
+     *
+     * @psalm-return 'schema'|'data'|'schema_and_data'
+     */
+    private function validateLogTypeParam($param): string
+    {
+        return in_array($param, ['schema', 'data'], true) ? $param : 'schema_and_data';
+    }
 }
