Remove redundant pass-by-ref

kamil-tekiela · MauricioFauth · commit d76b24017630 · 2023-02-10T16:30:12.000-03:00
Signed-off-by: Kamil Tekiela &lt;tekiela246@gmail.com&gt;
diff --git a/libraries/classes/Config/Validator.php b/libraries/classes/Config/Validator.php
@@ -126,7 +126,7 @@ public static function getValidators(ConfigFile $cf)
     public static function validate(
         ConfigFile $cf,
         $validatorId,
-        array &$values,
+        array $values,
         $isPostSource
     ) {
         // find validators
diff --git a/libraries/classes/Controllers/Table/StructureController.php b/libraries/classes/Controllers/Table/StructureController.php
@@ -195,7 +195,7 @@ protected function displayStructure(
         $row_comments = [];
         $extracted_columnspecs = [];
         $collations = [];
-        foreach ($fields as &$field) {
+        foreach ($fields as $field) {
             ++$rownum;
             $columns_list[] = $field['Field'];
 
diff --git a/libraries/classes/Core.php b/libraries/classes/Core.php
@@ -198,7 +198,7 @@ public static function getRealSize($size = 0): int
      * @param array  $allowList allow list to check page against
      * @param bool   $include   whether the page is going to be included
      */
-    public static function checkPageValidity(&$page, array $allowList = [], $include = false): bool
+    public static function checkPageValidity($page, array $allowList = [], $include = false): bool
     {
         if (empty($allowList)) {
             $allowList = ['index.php'];
diff --git a/libraries/classes/Git.php b/libraries/classes/Git.php
@@ -415,7 +415,7 @@ private function extractDataFormTextBody(array $commit): array
      *
      * @return stdClass|null The commit body from the GitHub API
      */
-    private function isRemoteCommit(&$commit, bool &$isRemoteCommit, string $hash): ?stdClass
+    private function isRemoteCommit($commit, bool &$isRemoteCommit, string $hash): ?stdClass
     {
         $httpRequest = new HttpRequest();
 
diff --git a/libraries/classes/Mime.php b/libraries/classes/Mime.php
@@ -26,7 +26,7 @@ class Mime
      *
      * @return string
      */
-    public static function detect(&$test)
+    public static function detect($test)
     {
         $len = mb_strlen($test);
         if ($len >= 2 && $test[0] == chr(0xff) && $test[1] == chr(0xd8)) {
diff --git a/libraries/classes/Plugins/Import/ImportMediawiki.php b/libraries/classes/Plugins/Import/ImportMediawiki.php
@@ -380,7 +380,7 @@ private function setTableHeaders(array &$table_headers, array $table_row): void
      *
      * @global string $db      name of the database to import in
      */
-    private function executeImportTables(array &$tables, array &$analyses, array &$sqlStatements): void
+    private function executeImportTables(array &$tables, array $analyses, array &$sqlStatements): void
     {
         // $db_name : The currently selected database name, if applicable
         //            No backquotes
diff --git a/libraries/classes/Sanitize.php b/libraries/classes/Sanitize.php
@@ -277,7 +277,7 @@ public static function getJsValue($key, $value)
      *
      * @param string[] $allowList list of variables to allow
      */
-    public static function removeRequestVars(&$allowList): void
+    public static function removeRequestVars($allowList): void
     {
         // do not check only $_REQUEST because it could have been overwritten
         // and use type casting because the variables could have become
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -2110,6 +2110,16 @@ parameters:
 			count: 1
 			path: libraries/classes/Controllers/Table/FindReplaceController.php
 
+		-
+			message: "#^Parameter \\#1 \\$str of function mb_strlen expects string, string\\|null given\\.$#"
+			count: 1
+			path: libraries/classes/Controllers/Table/GetFieldController.php
+
+		-
+			message: "#^Parameter \\#1 \\$test of static method PhpMyAdmin\\\\Mime\\:\\:detect\\(\\) expects string, string\\|null given\\.$#"
+			count: 1
+			path: libraries/classes/Controllers/Table/GetFieldController.php
+
 		-
 			message: "#^Parameter \\#1 \\$var of function count expects array\\|Countable, mixed given\\.$#"
 			count: 1
@@ -9585,6 +9595,11 @@ parameters:
 			count: 1
 			path: test/classes/CoreTest.php
 
+		-
+			message: "#^Parameter \\#1 \\$page of static method PhpMyAdmin\\\\Core\\:\\:checkPageValidity\\(\\) expects string, string\\|null given\\.$#"
+			count: 1
+			path: test/classes/CoreTest.php
+
 		-
 			message: "#^Method PhpMyAdmin\\\\Tests\\\\CreateAddFieldTest\\:\\:providerGetColumnCreationQueryRequest\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ public static function getRealSize($size = 0): int`
`198`	`198`	`* @param array $allowList allow list to check page against`
`199`	`199`	`* @param bool $include whether the page is going to be included`
`200`	`200`	`*/`
`201`		`- public static function checkPageValidity(&$page, array $allowList = [], $include = false): bool`
	`201`	`+ public static function checkPageValidity($page, array $allowList = [], $include = false): bool`
`202`	`202`	`{`
`203`	`203`	`if (empty($allowList)) {`
`204`	`204`	`$allowList = ['index.php'];`
Original file line number	Diff line number	Diff line change
`@@ -415,7 +415,7 @@ private function extractDataFormTextBody(array $commit): array`
`415`	`415`	`*`
`416`	`416`	`* @return stdClass\|null The commit body from the GitHub API`
`417`	`417`	`*/`
`418`		`- private function isRemoteCommit(&$commit, bool &$isRemoteCommit, string $hash): ?stdClass`
	`418`	`+ private function isRemoteCommit($commit, bool &$isRemoteCommit, string $hash): ?stdClass`
`419`	`419`	`{`
`420`	`420`	`$httpRequest = new HttpRequest();`
`421`	`421`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class Mime`
`26`	`26`	`*`
`27`	`27`	`* @return string`
`28`	`28`	`*/`
`29`		`- public static function detect(&$test)`
	`29`	`+ public static function detect($test)`
`30`	`30`	`{`
`31`	`31`	`$len = mb_strlen($test);`
`32`	`32`	`if ($len >= 2 && $test[0] == chr(0xff) && $test[1] == chr(0xd8)) {`
Original file line number	Diff line number	Diff line change
`@@ -380,7 +380,7 @@ private function setTableHeaders(array &$table_headers, array $table_row): void`
`380`	`380`	`*`
`381`	`381`	`* @global string $db name of the database to import in`
`382`	`382`	`*/`
`383`		`- private function executeImportTables(array &$tables, array &$analyses, array &$sqlStatements): void`
	`383`	`+ private function executeImportTables(array &$tables, array $analyses, array &$sqlStatements): void`
`384`	`384`	`{`
`385`	`385`	`// $db_name : The currently selected database name, if applicable`
`386`	`386`	`// No backquotes`
Original file line number	Diff line number	Diff line change
`@@ -277,7 +277,7 @@ public static function getJsValue($key, $value)`
`277`	`277`	`*`
`278`	`278`	`* @param string[] $allowList list of variables to allow`
`279`	`279`	`*/`
`280`		`- public static function removeRequestVars(&$allowList): void`
	`280`	`+ public static function removeRequestVars($allowList): void`
`281`	`281`	`{`
`282`	`282`	`// do not check only $_REQUEST because it could have been overwritten`
`283`	`283`	`// and use type casting because the variables could have become`