Merge pull request #18334 from kamil-tekiela/18333

MauricioFauth · web-flow · commit cf114bfc6e6f · 2023-04-09T14:18:54.000-03:00
Cast POST values to expected types
diff --git a/libraries/classes/Controllers/Table/FindReplaceController.php b/libraries/classes/Controllers/Table/FindReplaceController.php
@@ -146,7 +146,7 @@ public function findAction(): void
             && $_POST['useRegex'] === 'on';
 
         $preview = $this->getReplacePreview(
-            $_POST['columnIndex'],
+            (int) $_POST['columnIndex'],
             $_POST['find'],
             $_POST['replaceWith'],
             $useRegex,
@@ -158,10 +158,10 @@ public function findAction(): void
     public function replaceAction(): void
     {
         $this->replace(
-            $_POST['columnIndex'],
+            (int) $_POST['columnIndex'],
             $_POST['findString'],
             $_POST['replaceWith'],
-            $_POST['useRegex'],
+            (bool) $_POST['useRegex'],
             $this->connectionCharSet,
         );
         $this->response->addHTML(
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -3591,11 +3591,6 @@
     <InvalidArrayOffset>
       <code><![CDATA[$GLOBALS['errorUrl']]]></code>
     </InvalidArrayOffset>
-    <InvalidScalarArgument>
-      <code><![CDATA[$_POST['columnIndex']]]></code>
-      <code><![CDATA[$_POST['columnIndex']]]></code>
-      <code><![CDATA[$_POST['useRegex']]]></code>
-    </InvalidScalarArgument>
     <MixedArgument>
       <code>$column</code>
       <code>$column</code>
@@ -3641,6 +3636,10 @@
     <PossiblyUnusedParam>
       <code>$request</code>
     </PossiblyUnusedParam>
+    <RiskyCast>
+      <code><![CDATA[$_POST['columnIndex']]]></code>
+      <code><![CDATA[$_POST['columnIndex']]]></code>
+    </RiskyCast>
   </file>
   <file src="libraries/classes/Controllers/Table/GetFieldController.php">
     <PossiblyInvalidArgument>
