Disable Search input on unary operators (#19536)

faissaloux · web-flow · commit c97301ccfc9a · 2025-03-20T15:45:49.000-03:00
* disable input on unary operators

Signed-off-by: faissaloux &lt;fwahabali@gmail.com&gt;

* use toggle instead of show/hide

Signed-off-by: faissaloux &lt;fwahabali@gmail.com&gt;

* lint

Signed-off-by: faissaloux &lt;fwahabali@gmail.com&gt;

---------

Signed-off-by: faissaloux &lt;fwahabali@gmail.com&gt;
diff --git a/resources/js/src/table/select.ts b/resources/js/src/table/select.ts
@@ -44,6 +44,14 @@ const checkIfDataTypeNumericOrDate = function (dataType) {
 const TableSelect = {
     checkIfDataTypeNumericOrDate: checkIfDataTypeNumericOrDate,
 };
+const UNARY_OPERATORS = [
+    'IS NULL',
+    'IS NOT NULL',
+    '= \'\'',
+    '!= \'\''
+];
+
+const opIsUnary = (op) => UNARY_OPERATORS.includes(op);
 
 /**
  * Unbind all event handlers before tearing down a page
@@ -282,7 +290,6 @@ AJAX.registerOnload('table/select.js', function () {
      * Ajax event handler for Range-Search.
      */
     $('body').on('change', 'select[name*="criteriaColumnOperators"]', function () { // Fix for bug #13778, changed 'click' to 'change'
-        var $sourceSelect = $(this);
         // Get the column name.
         var columnName = $(this)
             .closest('tr')
@@ -298,7 +305,11 @@ AJAX.registerOnload('table/select.js', function () {
         dataType = TableSelect.checkIfDataTypeNumericOrDate(dataType);
 
         // Get the operator.
-        var operator = ($(this).val() as string);
+        const operator = ($(this).val() as string);
+        const $targetField = $(this).closest('tr').find('[name*="criteriaValues"]')
+
+        $targetField.prop('disabled', opIsUnary(operator));
+        $targetField.siblings('.ui-datepicker-trigger').eq(0).toggle(!opIsUnary(operator));
 
         if ((operator === 'BETWEEN' || operator === 'NOT BETWEEN') && dataType) {
             var $msgbox = ajaxShowMessage();
@@ -345,9 +356,6 @@ AJAX.registerOnload('table/select.js', function () {
                                     maxValue;
                             }
 
-                            var $targetField = $sourceSelect.closest('tr')
-                                .find('[name*="criteriaValues"]');
-
                             // If target field is a select list.
                             if ($targetField.is('select')) {
                                 $targetField.val(finalValue);
