fix #17779 - PHP 8 numeric operation (#17827)

aliber4079 · web-flow · commit c958e27bfaa3 · 2022-11-05T14:46:58.000-03:00
Fixes #17779 php8 throws exception in spite of @ symbol so work around it Signed-off-by: Alex Liberman <alex@zoosmart.us>
diff --git a/libraries/classes/Display/Results.php b/libraries/classes/Display/Results.php
@@ -738,9 +738,12 @@ private function getTableNavigation(
                 : 'false') . ';"';
 
         $hasRealEndInput = $isInnodb && $this->properties['unlim_num_rows'] > $GLOBALS['cfg']['MaxExactCount'];
-        $posLast = @((int) ceil(
-            (int) $this->properties['unlim_num_rows'] / $_SESSION['tmpval']['max_rows']
-        ) - 1) * intval($_SESSION['tmpval']['max_rows']);
+        $posLast = 0;
+        if (is_numeric($_SESSION['tmpval']['max_rows'])) {
+            $posLast = @((int) ceil(
+                (int) $this->properties['unlim_num_rows'] / $_SESSION['tmpval']['max_rows']
+            ) - 1) * intval($_SESSION['tmpval']['max_rows']);
+        }
 
         $hiddenFields = [
             'db' => $this->properties['db'],
