Fix export not working

MauricioFauth · MauricioFauth · commit 9faaad41ac27 · 2022-03-15T17:12:37.000-03:00
Signed-off-by: Maurício Meneghini Fauth &lt;mauricio@fauth.dev&gt;
diff --git a/libraries/classes/Controllers/Export/ExportController.php b/libraries/classes/Controllers/Export/ExportController.php
@@ -122,11 +122,11 @@ public function __invoke(ServerRequest $request): void
 
         $this->setGlobalsFromRequest($postParams);
 
-        $this->checkParameters(['what', 'export_type']);
-
         // sanitize this parameter which will be used below in a file inclusion
         $GLOBALS['what'] = Core::securePath($whatParam);
 
+        $this->checkParameters(['what', 'export_type']);
+
         // export class instance, not array of properties, as before
         $GLOBALS['export_plugin'] = Plugins::getPlugin('export', $GLOBALS['what'], [
             'export_type' => (string) $GLOBALS['export_type'],
diff --git a/test/classes/Controllers/Export/ExportControllerTest.php b/test/classes/Controllers/Export/ExportControllerTest.php
@@ -170,6 +170,9 @@ public function testExportController(): void
         $exportController = new ExportController(new ResponseRenderer(), new Template(), new Export($this->dbi));
         $exportController($request);
         $output = $this->getActualOutputForAssertion();
+
+        $this->assertStringNotContainsString('Missing parameter: what', $output);
+        $this->assertStringNotContainsString('Missing parameter: export_type', $output);
         $this->assertStringContainsString(htmlspecialchars($expectedOutput), $output);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,9 @@ public function testExportController(): void`
`170`	`170`	`$exportController = new ExportController(new ResponseRenderer(), new Template(), new Export($this->dbi));`
`171`	`171`	`$exportController($request);`
`172`	`172`	`$output = $this->getActualOutputForAssertion();`
	`173`	`+`
	`174`	`+ $this->assertStringNotContainsString('Missing parameter: what', $output);`
	`175`	`+ $this->assertStringNotContainsString('Missing parameter: export_type', $output);`
`173`	`176`	`$this->assertStringContainsString(htmlspecialchars($expectedOutput), $output);`
`174`	`177`	`}`
`175`	`178`	`}`