style: resolve lint issues.

og-khushalpatel · og-khushalpatel · commit 9f3b98319456 · 2026-03-09T11:53:14.000+05:30
Signed-off-by: Khushal Patel &lt;khushal.b.patel01@gmail.com&gt;
diff --git a/libraries/classes/Display/Results.php b/libraries/classes/Display/Results.php
@@ -51,7 +51,6 @@
 use function intval;
 use function is_array;
 use function is_numeric;
-use function is_string;
 use function json_encode;
 use function max;
 use function mb_check_encoding;
@@ -4419,8 +4418,8 @@ private function getRowData(
         array $analyzedSqlResults,
         FieldMetadata $meta,
         array $map,
-        $data,
-        $displayedData,
+        string $data,
+        string $displayedData,
         ?TransformationsPlugin $transformationPlugin,
         string $nowrap,
         string $whereComparison,
@@ -4441,10 +4440,7 @@ private function getRowData(
             $transformationPlugin !== null
         );
 
-        $canonicalValue = null;
-        if (is_string($data)) {
-            $canonicalValue = str_replace(["\r\n", "\r"], "\n", $data);
-        }
+        $canonicalValue = str_replace(["\r\n", "\r"], "\n", $data);
 
         if (! empty($analyzedSqlResults['statement']->expr)) {
             foreach ($analyzedSqlResults['statement']->expr as $expr) {
@@ -4561,7 +4557,7 @@ private function getRowData(
      *
      * @param string $value The string whose line endings should be detected
      *
-     * @return string|null  Returns 'CRLF', 'LF', or null if no line breaks exist
+     * @psalm-return 'CRLF'|'LF'|null
      */
     private function detectLineEnding(string $value): ?string
     {
@@ -4585,8 +4581,7 @@ private function detectLineEnding(string $value): ?string
      *
      * @param string $str string to be truncated
      *
-     * @return array
-     * @psalm-return array{bool, string, int}
+     * @psalm-return array{bool, string, int, 'CRLF'|'LF'|null}
      */
     private function getPartialText($str): array
     {
diff --git a/test/classes/Display/ResultsTest.php b/test/classes/Display/ResultsTest.php
@@ -1595,21 +1595,27 @@ public function testGetTable(): void
                 . '<td data-decimals="0" data-type="string" data-originallength="4" class="'
                 . 'data not_null text pre_wrap" data-original-value="abcd">abcd</td>' . "\n"
                 . '<td data-decimals="0" data-type="datetime" data-originallength="19" class="'
-                . 'data not_null datetimefield text-nowrap" data-original-value="2011-01-20&#x20;02&#x3A;00&#x3A;02">2011-01-20 02:00:02</td>' . "\n"
+                . 'data not_null datetimefield text-nowrap" '
+                . 'data-original-value="2011-01-20&#x20;02&#x3A;00&#x3A;02">2011-01-20 02:00:02</td>'
+                . "\n"
                 . '</tr>' . "\n"
                 . '<tr><td data-decimals="0" data-type="real" class="'
                 . 'text-end data not_null text-nowrap" data-original-value="2">2</td>' . "\n"
                 . '<td data-decimals="0" data-type="string" data-originallength="3" class="'
                 . 'data not_null text pre_wrap" data-original-value="foo">foo</td>' . "\n"
                 . '<td data-decimals="0" data-type="datetime" data-originallength="19" class="'
-                . 'data not_null datetimefield text-nowrap" data-original-value="2010-01-20&#x20;02&#x3A;00&#x3A;02">2010-01-20 02:00:02</td>' . "\n"
+                . 'data not_null datetimefield text-nowrap" '
+                . 'data-original-value="2010-01-20&#x20;02&#x3A;00&#x3A;02">2010-01-20 02:00:02</td>'
+                . "\n"
                 . '</tr>' . "\n"
                 . '<tr><td data-decimals="0" data-type="real" class="'
                 . 'text-end data not_null text-nowrap" data-original-value="3">3</td>' . "\n"
                 . '<td data-decimals="0" data-type="string" data-originallength="4" class="'
                 . 'data not_null text pre_wrap" data-original-value="Abcd">Abcd</td>' . "\n"
                 . '<td data-decimals="0" data-type="datetime" data-originallength="19" class="'
-                . 'data not_null datetimefield text-nowrap" data-original-value="2012-01-20&#x20;02&#x3A;00&#x3A;02">2012-01-20 02:00:02</td>' . "\n"
+                . 'data not_null datetimefield text-nowrap" '
+                . 'data-original-value="2012-01-20&#x20;02&#x3A;00&#x3A;02">2012-01-20 02:00:02</td>'
+                . "\n"
                 . '</tr>' . "\n",
             'bulk_links' => [],
             'operations' => [
